Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 83943005: Fix the doc comments for ui_test_pak. (Closed)

Created:
7 years, 1 month ago by tfarina
Modified:
7 years ago
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

Fix the doc comments for ui_test_pak. This passed from the review in https://codereview.chromium.org/45753004, crrev.com/234537 BUG=176960 R=tony@chromium.org TBR=ben Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236867

Patch Set 1 #

Total comments: 2

Patch Set 2 : reword #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/resources/ui_resources.gyp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
7 years, 1 month ago (2013-11-22 22:03:39 UTC) #1
tony
LGTM https://codereview.chromium.org/83943005/diff/1/ui/resources/ui_resources.gyp File ui/resources/ui_resources.gyp (right): https://codereview.chromium.org/83943005/diff/1/ui/resources/ui_resources.gyp#newcode40 ui/resources/ui_resources.gyp:40: # for tests. Nit: I would say, "This ...
7 years, 1 month ago (2013-11-22 22:57:32 UTC) #2
tfarina
https://codereview.chromium.org/83943005/diff/1/ui/resources/ui_resources.gyp File ui/resources/ui_resources.gyp (right): https://codereview.chromium.org/83943005/diff/1/ui/resources/ui_resources.gyp#newcode40 ui/resources/ui_resources.gyp:40: # for tests. On 2013/11/22 22:57:32, tony wrote: > ...
7 years, 1 month ago (2013-11-22 23:02:03 UTC) #3
tfarina
tbring Ben (trivial comment update).
7 years, 1 month ago (2013-11-22 23:23:17 UTC) #4
tfarina
Committed patchset #2 manually as r236867 (presubmit successful).
7 years, 1 month ago (2013-11-22 23:24:00 UTC) #5
Ben Goodger (Google)
7 years ago (2013-12-02 18:40:40 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698