content/renderer/render_view_impl.h - Issue 839413004: Remove the use of page id from building the commit params.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 839413004: Remove the use of page id from building the commit params. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test both enums (still fails site-per-process) Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_controller_impl_browsertest.cc ('K') | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index f8b0a313b01fbdb96bd786fbc11cb1817a97da08..f7b44f1039c9604697ccf53bdc02feac966b2290 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -857,13 +857,6 @@ class CONTENT_EXPORT RenderViewImpl

// See documentation in RenderView.

int32 page_id_;

- // Indicates the ID of the last page that we sent a FrameNavigate to the

- // browser for. This is used to determine if the most recent transition

- // generated a history entry (less than page_id_), or not (equal to or

- // greater than). Note that this will be greater than page_id_ if the user

- // goes back.

- int32 last_page_id_sent_to_browser_;

// The next available page ID to use for this RenderView. These IDs are

// specific to a given RenderView and the frames within it.

int32 next_page_id_;