Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: content/renderer/render_view_impl.h

Issue 839413004: Remove the use of page id from building the commit params. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git cl try Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 838 matching lines...) Expand 10 before | Expand all | Expand 10 after
849 // TODO(nasko): Move to RenderFrame, as this is per-frame state. 849 // TODO(nasko): Move to RenderFrame, as this is per-frame state.
850 scoped_ptr<FrameMsg_Navigate_Params> pending_navigation_params_; 850 scoped_ptr<FrameMsg_Navigate_Params> pending_navigation_params_;
851 851
852 // Timer used to delay the updating of nav state (see SyncNavigationState). 852 // Timer used to delay the updating of nav state (see SyncNavigationState).
853 base::OneShotTimer<RenderViewImpl> nav_state_sync_timer_; 853 base::OneShotTimer<RenderViewImpl> nav_state_sync_timer_;
854 854
855 // Page IDs ------------------------------------------------------------------ 855 // Page IDs ------------------------------------------------------------------
856 // See documentation in RenderView. 856 // See documentation in RenderView.
857 int32 page_id_; 857 int32 page_id_;
858 858
859 // Indicates the ID of the last page that we sent a FrameNavigate to the
860 // browser for. This is used to determine if the most recent transition
861 // generated a history entry (less than page_id_), or not (equal to or
862 // greater than). Note that this will be greater than page_id_ if the user
863 // goes back.
864 int32 last_page_id_sent_to_browser_;
865
866 // The next available page ID to use for this RenderView. These IDs are 859 // The next available page ID to use for this RenderView. These IDs are
867 // specific to a given RenderView and the frames within it. 860 // specific to a given RenderView and the frames within it.
868 int32 next_page_id_; 861 int32 next_page_id_;
869 862
870 // The offset of the current item in the history list. 863 // The offset of the current item in the history list.
871 int history_list_offset_; 864 int history_list_offset_;
872 865
873 // The RenderView's current impression of the history length. This includes 866 // The RenderView's current impression of the history length. This includes
874 // any items that have committed in this process, but because of cross-process 867 // any items that have committed in this process, but because of cross-process
875 // navigations, the history may have some entries that were committed in other 868 // navigations, the history may have some entries that were committed in other
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
1058 // use the Observer interface to filter IPC messages and receive frame change 1051 // use the Observer interface to filter IPC messages and receive frame change
1059 // notifications. 1052 // notifications.
1060 // --------------------------------------------------------------------------- 1053 // ---------------------------------------------------------------------------
1061 1054
1062 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl); 1055 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
1063 }; 1056 };
1064 1057
1065 } // namespace content 1058 } // namespace content
1066 1059
1067 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 1060 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698