Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 839303002: Document some skia perf interesting queries. (Closed)

Created:
5 years, 11 months ago by jcgregorio
Modified:
5 years, 11 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -0 lines) Patch
A site/dev/index.md View 1 chunk +4 lines, -0 lines 0 comments Download
A site/dev/tools/index.md View 1 chunk +6 lines, -0 lines 0 comments Download
A site/dev/tools/skiaperf.md View 1 chunk +36 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
jcgregorio
5 years, 11 months ago (2015-01-09 18:08:16 UTC) #2
mtklein
lgtm https://codereview.chromium.org/839303002/diff/1/site/dev/tools/skiaperf.md File site/dev/tools/skiaperf.md (right): https://codereview.chromium.org/839303002/diff/1/site/dev/tools/skiaperf.md#newcode36 site/dev/tools/skiaperf.md:36: See Skia Perf for the [full list of ...
5 years, 11 months ago (2015-01-09 18:22:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839303002/1
5 years, 11 months ago (2015-01-09 18:26:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/a91dc3140cb293da73c337fc1047ba1cd9b1c863
5 years, 11 months ago (2015-01-09 18:35:55 UTC) #6
jcgregorio
5 years, 11 months ago (2015-01-09 19:09:12 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/839303002/diff/1/site/dev/tools/skiaperf.md
File site/dev/tools/skiaperf.md (right):

https://codereview.chromium.org/839303002/diff/1/site/dev/tools/skiaperf.md#n...
site/dev/tools/skiaperf.md:36: See Skia Perf for the [full list of functions
available](https://skiaperf.com/help).
On 2015/01/09 18:22:00, mtklein wrote:
> I had no idea there was a skiaperf.com/help page.  Think we should add Help to
> the sidebar?

It's actually the '?' next to the formula input, but there's evidence that's not
discoverable enough :-)

I'll add it as a top level link in the next CL.

Powered by Google App Engine
This is Rietveld 408576698