Issue 8393009: Handle paths with raw strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8393009: Handle paths with raw strings (Closed)

Created:
9 years, 1 month ago by codefu

Modified:
9 years, 1 month ago

Reviewers:
mmendez, zundel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Handle paths with raw strings http://code.google.com/p/dart/issues/detail?id=109 R=mmendez,zundel@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=711

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	compiler/generate_source_list.py	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zundel

9 years, 1 month ago (2011-10-25 19:26:44 UTC) #3

http://codereview.chromium.org/8393009/diff/1/compiler/generate_source_list.py
File compiler/generate_source_list.py (right):

http://codereview.chromium.org/8393009/diff/1/compiler/generate_source_list.p...
compiler/generate_source_list.py:57: out.write('''      r'%s',%s''' %
(os.path.join(self.path, filename),'\n'))
PYTHON STYLE GUIDE VIOLATION ALERT:  need space after comma.

Expand Messages | Collapse Messages