Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 839233002: Don't serialize linking for the make generator by default (Closed)

Created:
5 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 11 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Don't serialize linking for the make generator by default Instead, projects that want this feature should define a LINK_wrapper BUG=none R=thakis@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=2022

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M pylib/gyp/generator/make.py View 2 chunks +1 line, -10 lines 0 comments Download
M test/make_global_settings/basics/gyptest-make_global_settings.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
ptal v8 still uses the make generator, however, we used to override LINK by default ...
5 years, 11 months ago (2015-01-09 14:12:09 UTC) #1
Nico
Does setting LINK to '$(CXX.target)' do the right thing for you?
5 years, 11 months ago (2015-01-10 01:14:35 UTC) #2
jochen (gone - plz use gerrit)
On 2015/01/10 at 01:14:35, thakis wrote: > Does setting LINK to '$(CXX.target)' do the right ...
5 years, 11 months ago (2015-01-12 08:30:33 UTC) #3
Nico
On 2015/01/12 08:30:33, jochen (slow) wrote: > On 2015/01/10 at 01:14:35, thakis wrote: > > ...
5 years, 11 months ago (2015-01-12 16:18:24 UTC) #4
jochen (gone - plz use gerrit)
On 2015/01/12 at 16:18:24, thakis wrote: > On 2015/01/12 08:30:33, jochen (slow) wrote: > > ...
5 years, 11 months ago (2015-01-13 10:52:13 UTC) #5
Nico
Ah, I see. lgtm, this seems simpler than making it work. Thanks!
5 years, 11 months ago (2015-01-13 15:55:38 UTC) #6
jochen (gone - plz use gerrit)
5 years, 11 months ago (2015-01-14 10:40:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r2022 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698