chrome/browser/ssl/ssl_error_classification.cc - Issue 839183002: Remove redundancy in security interstitial UMA logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_error_classification.cc

Issue 839183002: Remove redundancy in security interstitial UMA logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ... Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ssl/ssl_error_classification.cc

diff --git a/chrome/browser/ssl/ssl_error_classification.cc b/chrome/browser/ssl/ssl_error_classification.cc

index 324bc18eced1f735bf0890fa61f5b395cbd68903..4adc9b7290758e5b969f32068b100aeee6cbd022 100644

--- a/chrome/browser/ssl/ssl_error_classification.cc

+++ b/chrome/browser/ssl/ssl_error_classification.cc

@@ -297,6 +297,8 @@ void SSLErrorClassification::RecordUMAStatistics(

bool overridable) const {

SSLErrorInfo::ErrorType type =

SSLErrorInfo::NetErrorToErrorType(cert_error_);

+ UMA_HISTOGRAM_ENUMERATION(

+ "interstitial.ssl_error_type", type, SSLErrorInfo::END_OF_ENUM);

switch (type) {

case SSLErrorInfo::CERT_DATE_INVALID: {

if (IsUserClockInThePast(base::Time::NowFromSystemTime()))

« no previous file with comments | « chrome/browser/ssl/ssl_blocking_page.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »