Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 839173003: Gallery: Fix enterMode. (Closed)

Created:
5 years, 11 months ago by hirono
Modified:
5 years, 11 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gallery: Fix binding of toggleMode method. Previously the first argument of toggleMode function passed to the event handler was not bounded. Thus event object is passed to the first argument of toggleMode unintentionally. BUG=447519 TEST=None Committed: https://crrev.com/93321f0483086cb20aa9eb2ce9ab1b383f28e8c7 Cr-Commit-Position: refs/heads/master@{#310757}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/file_manager/gallery/js/gallery.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/gallery/js/mosaic_mode.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
hirono
PTAL, thanks!
5 years, 11 months ago (2015-01-09 11:06:21 UTC) #5
mtomasz
lgtm
5 years, 11 months ago (2015-01-09 11:30:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839173003/60001
5 years, 11 months ago (2015-01-09 11:39:07 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:60001)
5 years, 11 months ago (2015-01-09 11:42:57 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 11:43:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93321f0483086cb20aa9eb2ce9ab1b383f28e8c7
Cr-Commit-Position: refs/heads/master@{#310757}

Powered by Google App Engine
This is Rietveld 408576698