Issue 839163003: Adds an alarm for sending a QUIC FEC packet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 839163003: Adds an alarm for sending a QUIC FEC packet. (Closed)

Created:
5 years, 11 months ago by ramant (doing other things)

Modified:
5 years, 11 months ago

Reviewers:
Jana, Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Tell_QUIC_AckNotifierManager_83525991

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Adds an alarm for sending a QUIC FEC packet. This CL adds an alarm for sending an FEC packet. The alarm is based on the connection's SRTT, and is set when the first FEC protected packet in an FEC group is sent. This alarm puts some time between the sending of an FEC protected packet and the corresponding FEC packet, to reduce the probability of both these packets getting dropped in the network. Merge internal change: 83543120 R=jri@chromium.org, rch@chromium.org

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+644 lines, -197 lines)			Patch
M	net/quic/quic_connection.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	net/quic/quic_connection.cc	View	7 chunks	+36 lines, -0 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	31 chunks	+309 lines, -124 lines	0 comments	Download
M	net/quic/quic_packet_creator.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	net/quic/quic_packet_generator.h	View	4 chunks	+16 lines, -3 lines	0 comments	Download
M	net/quic/quic_packet_generator.cc	View	6 chunks	+46 lines, -22 lines	0 comments	Download
M	net/quic/quic_packet_generator_test.cc	View	19 chunks	+211 lines, -48 lines	0 comments	Download
M	net/quic/test_tools/quic_connection_peer.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/test_tools/quic_connection_peer.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	net/quic/test_tools/quic_packet_generator_peer.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/test_tools/quic_packet_generator_peer.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

"git cl format net" has re-formatted code slightly. There were no changes to Jana's code ...

5 years, 11 months ago (2015-01-14 01:53:05 UTC) #2

lgtm

Expand Messages | Collapse Messages