Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 839153005: Revert of Push API: Add temporary debug log to track down crash (Closed)

Created:
5 years, 11 months ago by mattm
Modified:
5 years, 11 months ago
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@handlercount
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Push API: Add temporary debug log to track down crash (patchset #2 id:20001 of https://codereview.chromium.org/846473003/) Reason for revert: Speculative revert for Android Tests unit_tests failures. 170 tests consistently crashing/failing with nothing printed in the log (ex: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/17673/steps/unit_tests/logs/stdio [ RUN ] BrowsingDataRemoverTest.RemoveMultipleTypes [ CRASHED ] ) Original issue's description: > Push API: Add temporary debug log to track down crash > > Specifically, for https://goto.google.com/gcmdriver-already-instantiated > > Sample output: > [FATAL:gcm_profile_service.cc(155)] An instance of GCMProfileService already exists! Old profile: 0x9e9d75c0 Default 0 0 1 13065207799278578, new profile: 0x9e9d75c0 Default 0 0 1 13065207799278578 > > BUG=437827 > > Committed: https://crrev.com/934554c3f369c9821b0af3ae8a09ed55f29eafc9 > Cr-Commit-Position: refs/heads/master@{#310593} TBR=bauerb@chromium.org,jianli@chromium.org,johnme@chromium.org NOTREECHECKS=true NOTRY=true BUG=437827 Committed: https://crrev.com/8cffa4a77d03ec8e83f1704ad052fd5b92875032 Cr-Commit-Position: refs/heads/master@{#310683}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -21 lines) Patch
M chrome/browser/services/gcm/gcm_profile_service.cc View 1 chunk +1 line, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mattm
Created Revert of Push API: Add temporary debug log to track down crash
5 years, 11 months ago (2015-01-09 02:36:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839153005/1
5 years, 11 months ago (2015-01-09 02:38:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 02:40:40 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 02:41:54 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8cffa4a77d03ec8e83f1704ad052fd5b92875032
Cr-Commit-Position: refs/heads/master@{#310683}

Powered by Google App Engine
This is Rietveld 408576698