Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 839153002: Fix crash in continuations. (Closed)

Created:
5 years, 11 months ago by ojan
Modified:
5 years, 11 months ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix crash in continuations. Style sharing didn't play nicely with elements getting their display adjusted based off the parent's display. We style share without doing adjusting, so we need to avoid style sharing if adjusting would result in a different style. Particularly, we need to make sure that the display coercion would happen in the same way. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/613fddedfda822503464aaf1740c5c42f8aa0dfa

Patch Set 1 #

Total comments: 2

Patch Set 2 : address review nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -28 lines) Patch
M sky/engine/core/css/resolver/SharedStyleFinder.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M sky/engine/core/css/resolver/StyleAdjuster.cpp View 1 2 chunks +1 line, -23 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.cpp View 1 1 chunk +22 lines, -0 lines 0 comments Download
M sky/tests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/tests/layout/continuations-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
esprehn
lgtm, fix nit before landing. https://codereview.chromium.org/839153002/diff/1/sky/engine/core/css/resolver/StyleAdjuster.cpp File sky/engine/core/css/resolver/StyleAdjuster.cpp (right): https://codereview.chromium.org/839153002/diff/1/sky/engine/core/css/resolver/StyleAdjuster.cpp#newcode142 sky/engine/core/css/resolver/StyleAdjuster.cpp:142: if (RenderStyle::requiresOnlyBlockChildren(parentStyle)) parentStyle->requiresOnlyBlockChildren() https://codereview.chromium.org/839153002/diff/1/sky/engine/core/rendering/style/RenderStyle.cpp ...
5 years, 11 months ago (2015-01-09 00:56:58 UTC) #2
ojan
5 years, 11 months ago (2015-01-09 01:20:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
613fddedfda822503464aaf1740c5c42f8aa0dfa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698