Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: sandbox/linux/services/credentials.cc

Issue 839143002: Roll Chrome into Mojo. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/linux/services/credentials.h ('k') | sandbox/linux/services/credentials_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/linux/services/credentials.cc
diff --git a/sandbox/linux/services/credentials.cc b/sandbox/linux/services/credentials.cc
index f926ce8e85dcc117dabf85ece4f8581c728b94f7..c1283ea61a02b12fb53120444b320f89fa3d509f 100644
--- a/sandbox/linux/services/credentials.cc
+++ b/sandbox/linux/services/credentials.cc
@@ -21,7 +21,6 @@
#include "base/template_util.h"
#include "base/third_party/valgrind/valgrind.h"
#include "base/threading/thread.h"
-#include "sandbox/linux/services/proc_util.h"
#include "sandbox/linux/services/syscall_wrappers.h"
namespace {
@@ -59,7 +58,8 @@ struct FILECloser {
// TODO(jln): fix base/.
typedef scoped_ptr<FILE, FILECloser> ScopedFILE;
-COMPILE_ASSERT((base::is_same<uid_t, gid_t>::value), UidAndGidAreSameType);
+static_assert((base::is_same<uid_t, gid_t>::value),
+ "uid_t and gid_t should be the same type");
// generic_id_t can be used for either uid_t or gid_t.
typedef uid_t generic_id_t;
@@ -101,8 +101,8 @@ void ChrootToThreadFdInfo(base::PlatformThreadId tid, bool* result) {
DCHECK(result);
*result = false;
- COMPILE_ASSERT((base::is_same<base::PlatformThreadId, int>::value),
- TidIsAnInt);
+ static_assert((base::is_same<base::PlatformThreadId, int>::value),
+ "platform thread id should be an int");
const std::string current_thread_fdinfo = "/proc/" +
base::IntToString(tid) + "/fdinfo/";
@@ -248,9 +248,6 @@ bool Credentials::MoveToNewUserNS() {
}
bool Credentials::DropFileSystemAccess() {
- // Chrooting to a safe empty dir will only be safe if no directory file
- // descriptor is available to the process.
- DCHECK(!ProcUtil::HasOpenDirectory(-1));
return ChrootToSafeEmptyDir();
}
« no previous file with comments | « sandbox/linux/services/credentials.h ('k') | sandbox/linux/services/credentials_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698