Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1553)

Unified Diff: skia/ext/pixel_ref_utils.cc

Issue 839143002: Roll Chrome into Mojo. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « skia/ext/image_operations_unittest.cc ('k') | skia/ext/pixel_ref_utils_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/ext/pixel_ref_utils.cc
diff --git a/skia/ext/pixel_ref_utils.cc b/skia/ext/pixel_ref_utils.cc
index 777c2533024945fe611130eaabded6bdded516d8..7029d46ff6b6eccd9e3b827966753f5f8edc4b38 100644
--- a/skia/ext/pixel_ref_utils.cc
+++ b/skia/ext/pixel_ref_utils.cc
@@ -93,8 +93,8 @@ class GatherPixelRefDevice : public SkBitmapDevice {
if (GetBitmapFromPaint(paint, &bitmap)) {
SkRect mapped_rect;
draw.fMatrix->mapRect(&mapped_rect, rect);
- mapped_rect.intersect(SkRect::Make(draw.fRC->getBounds()));
- AddBitmap(bitmap, mapped_rect);
+ if (mapped_rect.intersect(SkRect::Make(draw.fRC->getBounds())))
+ AddBitmap(bitmap, mapped_rect);
}
}
void drawOval(const SkDraw& draw,
@@ -327,8 +327,8 @@ class GatherPixelRefDevice : public SkBitmapDevice {
void AddBitmap(const SkBitmap& bm, const SkRect& rect) {
SkRect canvas_rect = SkRect::MakeWH(width(), height());
SkRect paint_rect = SkRect::MakeEmpty();
- paint_rect.intersect(rect, canvas_rect);
- pixel_ref_set_->Add(bm.pixelRef(), paint_rect);
+ if (paint_rect.intersect(rect, canvas_rect))
+ pixel_ref_set_->Add(bm.pixelRef(), paint_rect);
}
bool GetBitmapFromPaint(const SkPaint& paint, SkBitmap* bm) {
« no previous file with comments | « skia/ext/image_operations_unittest.cc ('k') | skia/ext/pixel_ref_utils_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698