Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: third_party/cython/rules.gni

Issue 839143002: Roll Chrome into Mojo. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/boringssl/boringssl_unittest.cc ('k') | third_party/harfbuzz-ng/README.chromium » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/cython/rules.gni
diff --git a/third_party/cython/rules.gni b/third_party/cython/rules.gni
index 5cfea1ab45aa66210ef8e1a53eee927f5ac0bb90..04a9953e1df16b37b2f2901e1d829609b1b7f29c 100644
--- a/third_party/cython/rules.gni
+++ b/third_party/cython/rules.gni
@@ -82,7 +82,8 @@ template("python_binary_module") {
has_sources = defined(invoker.cython_sources) || defined(invoker.sources)
assert(has_sources || defined(invoker.deps))
- assert(defined(invoker.python_base_module))
+ assert(
+ !defined(invoker.python_base_module) || invoker.python_base_module != "")
sources_target_name = target_name + "_cython_sources"
shared_library_name = target_name + "_shared_library"
@@ -138,12 +139,18 @@ template("python_binary_module") {
}
copy(target_name) {
- python_base_module = invoker.python_base_module
+ if (defined(invoker.python_base_module)) {
+ python_base_module = invoker.python_base_module
+ output = "$root_out_dir/python/$python_base_module/${target_name}${python_module_suffix}"
+ } else {
+ output = "$root_out_dir/python/${target_name}${python_module_suffix}"
+ }
+
sources = [
"$root_out_dir/${shared_library_prefix}${shared_library_name}${shared_library_suffix}",
]
outputs = [
- "$root_out_dir/python/$python_base_module/${target_name}${python_module_suffix}",
+ output,
]
deps = [
":$shared_library_name",
« no previous file with comments | « third_party/boringssl/boringssl_unittest.cc ('k') | third_party/harfbuzz-ng/README.chromium » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698