Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2168)

Unified Diff: cc/layers/picture_layer_impl.cc

Issue 839143002: Roll Chrome into Mojo. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/picture_layer_impl.h ('k') | cc/layers/picture_layer_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/picture_layer_impl.cc
diff --git a/cc/layers/picture_layer_impl.cc b/cc/layers/picture_layer_impl.cc
index 5a192a04ee4bda1ed6c7bb1ce5a2eb2f3e42e34b..49e4d1f93226c2f3b7f95dad7f707d4cb4e829f4 100644
--- a/cc/layers/picture_layer_impl.cc
+++ b/cc/layers/picture_layer_impl.cc
@@ -342,15 +342,10 @@ void PictureLayerImpl::AppendQuads(RenderPass* render_pass,
TileDrawQuad* quad =
render_pass->CreateAndAppendDrawQuad<TileDrawQuad>();
- quad->SetNew(shared_quad_state,
- geometry_rect,
- opaque_rect,
- visible_geometry_rect,
- draw_info.get_resource_id(),
- texture_rect,
- iter.texture_size(),
- draw_info.contents_swizzled(),
- nearest_neighbor_);
+ quad->SetNew(shared_quad_state, geometry_rect, opaque_rect,
+ visible_geometry_rect, draw_info.resource_id(),
+ texture_rect, draw_info.resource_size(),
+ draw_info.contents_swizzled(), nearest_neighbor_);
has_draw_quad = true;
break;
}
@@ -371,20 +366,18 @@ void PictureLayerImpl::AppendQuads(RenderPass* render_pass,
PictureDrawQuad* quad =
render_pass->CreateAndAppendDrawQuad<PictureDrawQuad>();
quad->SetNew(shared_quad_state, geometry_rect, opaque_rect,
- visible_geometry_rect, texture_rect, iter.texture_size(),
- nearest_neighbor_, format, iter->content_rect(),
- iter->contents_scale(), raster_source_);
+ visible_geometry_rect, texture_rect,
+ iter->desired_texture_size(), nearest_neighbor_, format,
+ iter->content_rect(), iter->contents_scale(),
+ raster_source_);
has_draw_quad = true;
break;
}
case TileDrawInfo::SOLID_COLOR_MODE: {
SolidColorDrawQuad* quad =
render_pass->CreateAndAppendDrawQuad<SolidColorDrawQuad>();
- quad->SetNew(shared_quad_state,
- geometry_rect,
- visible_geometry_rect,
- draw_info.get_solid_color(),
- false);
+ quad->SetNew(shared_quad_state, geometry_rect, visible_geometry_rect,
+ draw_info.solid_color(), false);
has_draw_quad = true;
break;
}
@@ -449,7 +442,7 @@ void PictureLayerImpl::AppendQuads(RenderPass* render_pass,
CleanUpTilingsOnActiveLayer(seen_tilings);
}
-void PictureLayerImpl::UpdateTiles(const Occlusion& occlusion_in_content_space,
+bool PictureLayerImpl::UpdateTiles(const Occlusion& occlusion_in_content_space,
bool resourceless_software_draw) {
DCHECK_EQ(1.f, contents_scale_x());
DCHECK_EQ(1.f, contents_scale_y());
@@ -464,7 +457,7 @@ void PictureLayerImpl::UpdateTiles(const Occlusion& occlusion_in_content_space,
ideal_contents_scale_ = 0.f;
ideal_source_scale_ = 0.f;
SanityCheckTilingState();
- return;
+ return false;
}
UpdateIdealScales();
@@ -488,10 +481,10 @@ void PictureLayerImpl::UpdateTiles(const Occlusion& occlusion_in_content_space,
should_update_tile_priorities_ = true;
- UpdateTilePriorities(occlusion_in_content_space);
+ return UpdateTilePriorities(occlusion_in_content_space);
}
-void PictureLayerImpl::UpdateTilePriorities(
+bool PictureLayerImpl::UpdateTilePriorities(
const Occlusion& occlusion_in_content_space) {
DCHECK_IMPLIES(raster_source_->IsSolidColor(), tilings_->num_tilings() == 0);
@@ -523,10 +516,7 @@ void PictureLayerImpl::UpdateTilePriorities(
viewport_rect_in_layer_space, ideal_contents_scale_,
current_frame_time_in_seconds, occlusion_in_content_space,
can_require_tiles_for_activation);
-
- // TODO(vmpstr): See if this can be removed in favour of calling it from LTHI
- if (updated)
- layer_tree_impl()->DidModifyTilePriorities();
+ return updated;
}
gfx::Rect PictureLayerImpl::GetViewportForTilePriorityInContentSpace() const {
@@ -611,12 +601,6 @@ void PictureLayerImpl::NotifyTileStateChanged(const Tile* tile) {
}
}
-void PictureLayerImpl::DidBecomeActive() {
- LayerImpl::DidBecomeActive();
- // TODO(vmpstr): See if this can be removed in favour of calling it from LTHI
- layer_tree_impl()->DidModifyTilePriorities();
-}
-
void PictureLayerImpl::DidBeginTracing() {
raster_source_->DidBeginTracing();
}
@@ -797,8 +781,8 @@ void PictureLayerImpl::GetContentsResourceId(
return;
}
- *resource_id = draw_info.get_resource_id();
- *resource_size = iter.texture_size();
+ *resource_id = draw_info.resource_id();
+ *resource_size = draw_info.resource_size();
}
void PictureLayerImpl::SetNearestNeighbor(bool nearest_neighbor) {
« no previous file with comments | « cc/layers/picture_layer_impl.h ('k') | cc/layers/picture_layer_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698