Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: net/quic/congestion_control/pacing_sender.h

Issue 839143002: Roll Chrome into Mojo. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/transport_security_state_unittest.cc ('k') | net/quic/congestion_control/pacing_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/congestion_control/pacing_sender.h
diff --git a/net/quic/congestion_control/pacing_sender.h b/net/quic/congestion_control/pacing_sender.h
index 854b0525c1ddc5c3eb547b67f7a351ef00aebeee..4531dce8ac93e9e314b1d63ba5062e27873ba039 100644
--- a/net/quic/congestion_control/pacing_sender.h
+++ b/net/quic/congestion_control/pacing_sender.h
@@ -2,11 +2,11 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
-// A send algorithm which adds pacing on top of an another send algorithm.
-// It uses the underlying sender's bandwidth estimate to determine the
-// pacing rate to be used. It also takes into consideration the expected
-// resolution of the underlying alarm mechanism to ensure that alarms are
-// not set too aggressively, and to smooth out variations.
+// A send algorithm that adds pacing on top of an another send algorithm.
+// It uses the underlying sender's pacing rate to schedule packets.
+// It also takes into consideration the expected granularity of the underlying
+// alarm to ensure that alarms are not set too aggressively, and err towards
+// sending packets too early instead of too late.
#ifndef NET_QUIC_CONGESTION_CONTROL_PACING_SENDER_H_
#define NET_QUIC_CONGESTION_CONTROL_PACING_SENDER_H_
@@ -70,12 +70,15 @@ class NET_EXPORT_PRIVATE PacingSender : public SendAlgorithmInterface {
private:
scoped_ptr<SendAlgorithmInterface> sender_; // Underlying sender.
- QuicTime::Delta alarm_granularity_;
- uint32 initial_packet_burst_;
- mutable uint32 burst_tokens_;
+ // The estimated system alarm granularity.
+ const QuicTime::Delta alarm_granularity_;
+ // Configured size of the burst coming out of quiescence.
+ const uint32 initial_packet_burst_;
+ // Number of unpaced packets to be sent before packets are delayed.
+ uint32 burst_tokens_;
// Send time of the last packet considered delayed.
QuicTime last_delayed_packet_sent_time_;
- QuicTime next_packet_send_time_; // When can the next packet be sent.
+ QuicTime ideal_next_packet_send_time_; // When can the next packet be sent.
mutable bool was_last_send_delayed_; // True when the last send was delayed.
DISALLOW_COPY_AND_ASSIGN(PacingSender);
« no previous file with comments | « net/http/transport_security_state_unittest.cc ('k') | net/quic/congestion_control/pacing_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698