tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.txt - Issue 839143002: Roll Chrome into Mojo.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.txt

Issue 839143002: Roll Chrome into Mojo. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Rebase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 In file included from class_multiple_trace_bases.cpp:5:	1 In file included from class_multiple_trace_bases.cpp:5:

2 ./class_multiple_trace_bases.h:22:1: warning: [blink-gc] Class 'Derived' require s a trace method.	2 ./class_multiple_trace_bases.h:22:1: warning: [blink-gc] Class 'Derived' require s a trace method.

3 class Derived : public Base, public Mixin {	3 class Derived : public Base, public Mixin {

4 ^	4 ^

5 ./class_multiple_trace_bases.h:22:17: note: [blink-gc] Untraced base class 'Base ' declared here:	5 ./class_multiple_trace_bases.h:22:17: note: [blink-gc] Untraced base class 'Base ' declared here:

6 class Derived : public Base, public Mixin {	6 class Derived : public Base, public Mixin {

7 ^	7 ^

8 ./class_multiple_trace_bases.h:22:30: note: [blink-gc] Untraced base class 'Mixi n' declared here:	8 ./class_multiple_trace_bases.h:22:30: note: [blink-gc] Untraced base class 'Mixi n' declared here:

9 class Derived : public Base, public Mixin {	9 class Derived : public Base, public Mixin {

10 ^	10 ^

11 1 warning generated.	11 ./class_multiple_trace_bases.h:22:1: warning: [blink-gc] Class 'Derived' which i nherits from GarbageCollectedMixin must locally declare and override trace(Visit or*)

	12 class Derived : public Base, public Mixin {

	13 ^

	14 2 warnings generated.

OLD	NEW