Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 8391004: Add webstorePrivate API for installing bundles of extensions. (Closed)

Created:
9 years, 2 months ago by jstritar
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

Add webstorePrivate API for installing bundles of extensions. Adds an extension API that lets the webstore app install bundles of extensions. The WebstoreBundle class manages the installation life cycle of extension bundles. Note: the UI will be in separate CLs. BUG=98687 TEST=*Webstore*

Patch Set 1 #

Patch Set 2 : add test for WebstorePendingInstall #

Patch Set 3 : start adding a test for WebstoreBundle #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : add webstorebundle browser test #

Patch Set 7 : . #

Patch Set 8 : simplify api #

Patch Set 9 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1406 lines, --1 lines) Patch
M chrome/browser/extensions/crx_installer.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 2 3 4 5 6 7 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.h View 1 2 3 4 5 6 7 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 1 2 3 4 5 6 7 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_webstore_private_api.h View 1 2 3 4 5 6 7 2 chunks +42 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_webstore_private_api.cc View 1 2 3 4 5 6 7 8 2 chunks +88 lines, -0 lines 0 comments Download
A chrome/browser/extensions/webstore_bundle.h View 1 2 3 4 5 1 chunk +249 lines, -0 lines 0 comments Download
A chrome/browser/extensions/webstore_bundle.cc View 1 2 3 4 5 6 7 1 chunk +363 lines, -0 lines 0 comments Download
A chrome/browser/extensions/webstore_bundle_browsertest.cc View 1 2 3 4 5 6 7 1 chunk +477 lines, -0 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 1 2 3 4 5 3 chunks +10 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/extension_api.json View 1 2 3 4 5 6 7 3 chunks +48 lines, -1 line 0 comments Download
A chrome/test/data/extensions/api_test/webstore_private/bundle/begfmnajjkbjdgmffnjaojchoncnmngg.crx View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/extensions/api_test/webstore_private/bundle/begfmnajjkbjdgmffnjaojchoncnmngg.pem View 1 2 3 4 5 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/webstore_private/bundle/begfmnajjkbjdgmffnjaojchoncnmngg/manifest.json View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/webstore_private/bundle/bmfoocgfinpmkmlbjhcbofejhkhlbchk.crx View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/extensions/api_test/webstore_private/bundle/bmfoocgfinpmkmlbjhcbofejhkhlbchk.pem View 1 2 3 4 5 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/webstore_private/bundle/bmfoocgfinpmkmlbjhcbofejhkhlbchk/manifest.json View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/webstore_private/bundle/cccccccccccccccccccccccccccccccc.crx View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/webstore_private/bundle/mpneghmdnmaolkljkipbhaienajcflfe.crx View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/extensions/api_test/webstore_private/bundle/mpneghmdnmaolkljkipbhaienajcflfe.pem View 1 2 3 4 5 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/webstore_private/bundle/mpneghmdnmaolkljkipbhaienajcflfe/content_script.js View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/webstore_private/bundle/mpneghmdnmaolkljkipbhaienajcflfe/manifest.json View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/webstore_private/bundle/pkapffpjmiilhlhbibjhamlmdhfneidj.crx View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/extensions/api_test/webstore_private/bundle/pkapffpjmiilhlhbibjhamlmdhfneidj.pem View 1 2 3 4 5 1 chunk +15 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/webstore_private/bundle/pkapffpjmiilhlhbibjhamlmdhfneidj/manifest.json View 1 2 3 4 5 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jstritar
The rest of the bundles code, excluding UI. I'm working on a unit test for ...
9 years, 2 months ago (2011-10-25 16:38:38 UTC) #1
jstritar
Added a test for WebstoreBundle to approve / deny state transitions and a few other ...
9 years, 2 months ago (2011-10-25 18:46:35 UTC) #2
jstritar
+aa
9 years, 2 months ago (2011-10-25 19:25:14 UTC) #3
Mihai Parparita -not on Chrome
On Tue, Oct 25, 2011 at 9:38 AM, <jstritar@chromium.org> wrote: > A browser test is ...
9 years, 2 months ago (2011-10-25 20:12:47 UTC) #4
jstritar_google
Actually, good point. The redirect is just for the user's convenience and this shouldn't rely ...
9 years, 2 months ago (2011-10-25 20:13:46 UTC) #5
jstritar
I added a browser test for WebstoreBundle, so I think this is ready to go. ...
9 years, 1 month ago (2011-10-26 18:40:27 UTC) #6
jstritar
9 years, 1 month ago (2011-10-27 22:26:38 UTC) #7
I got rid of the two step API. This simplified things a bit since we no longer
need WebstorePendingInstalls.

Powered by Google App Engine
This is Rietveld 408576698