Convert KeyInformation from Pepper type to MediaKeys

Convert KeyInformation from Pepper type to MediaKeys

Now that Pepper passes the KeyInformation across and MediaKeys can
handle it, convert the data and pass it on.

BUG=428384
TEST=existing EME tests pass

Committed: https://crrev.com/a261cb0d164c411e916fb62f4c560ce5acb260f3
Cr-Commit-Position: refs/heads/master@{#310815}

[jrummell, 2015-01-09 01:24:16]

jrummell@chromium.org changed reviewers:
+ ddorwin@chromium.org, dmichael@chromium.org, sandersd@chromium.org

[jrummell, 2015-01-09 01:24:17]

Finally, the last piece of the Pepper changes. PTAL.

[ddorwin, 2015-01-09 03:27:36]

LGTM with comments for the future and one optional suggestion.

https://codereview.chromium.org/839063004/diff/1/content/renderer/pepper/cont...
File content/renderer/pepper/content_decryptor_delegate.cc (right):

https://codereview.chromium.org/839063004/diff/1/content/renderer/pepper/cont...
content/renderer/pepper/content_decryptor_delegate.cc:300: case
PP_CDMKEYSTATUS_INVALID:
We should fix the naming sometime.

https://codereview.chromium.org/839063004/diff/1/content/renderer/pepper/cont...
content/renderer/pepper/content_decryptor_delegate.cc:304: case
PP_CDMKEYSTATUS_OUTPUTNOTALLOWED:
And this probably shouldn't be one word.

https://codereview.chromium.org/839063004/diff/1/content/renderer/pepper/cont...
content/renderer/pepper/content_decryptor_delegate.cc:790:
key_information[i].key_id,
nit: With 5 references to it, you might consider making an alias (const ref) to
key_information[i]. Something like "info" might make this short enough to fit,
but it's also ambiguous with all the key_info[s] names.

[dmichael (off chromium), 2015-01-09 16:22:53]

OWNERS lgtm

[jrummell, 2015-01-09 17:24:29]

Thanks for the reviews.

https://codereview.chromium.org/839063004/diff/1/content/renderer/pepper/cont...
File content/renderer/pepper/content_decryptor_delegate.cc (right):

https://codereview.chromium.org/839063004/diff/1/content/renderer/pepper/cont...
content/renderer/pepper/content_decryptor_delegate.cc:300: case
PP_CDMKEYSTATUS_INVALID:
On 2015/01/09 03:27:36, ddorwin wrote:
> We should fix the naming sometime.

Acknowledged.

https://codereview.chromium.org/839063004/diff/1/content/renderer/pepper/cont...
content/renderer/pepper/content_decryptor_delegate.cc:304: case
PP_CDMKEYSTATUS_OUTPUTNOTALLOWED:
On 2015/01/09 03:27:35, ddorwin wrote:
> And this probably shouldn't be one word.

Acknowledged.

https://codereview.chromium.org/839063004/diff/1/content/renderer/pepper/cont...
content/renderer/pepper/content_decryptor_delegate.cc:790:
key_information[i].key_id,
On 2015/01/09 03:27:36, ddorwin wrote:
> nit: With 5 references to it, you might consider making an alias (const ref)
to
> key_information[i]. Something like "info" might make this short enough to fit,
> but it's also ambiguous with all the key_info[s] names.

Done. I would think the compilers are smart enough these days to do it, but I'll
make it explicit.

[jrummell, 2015-01-09 17:24:32]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2015-01-09 17:24:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/839063004/20001

[commit-bot: I haz the power, 2015-01-09 19:31:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-09 19:33:13]

Patchset 2 (id:??) landed as
https://crrev.com/a261cb0d164c411e916fb62f4c560ce5acb260f3
Cr-Commit-Position: refs/heads/master@{#310815}