Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1842)

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc

Issue 839063003: By default, remove user gesture restriction from permission bubbles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove debugging statement Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc
diff --git a/chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc b/chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc
index 2e1ea07385cbafc840c27df432d51663d3631b07..c866fb1452afdff6f8ea4474a9739c674226ca1d 100644
--- a/chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc
+++ b/chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc
@@ -521,3 +521,43 @@ TEST_F(PermissionBubbleManagerTest, AllUserGestureRequests) {
EXPECT_TRUE(iframe_request_other_domain_.finished());
EXPECT_FALSE(view_.shown_);
}
+
+TEST_F(PermissionBubbleManagerTest, RequestsWithoutUserGesture) {
+ manager_->RequireUserGesture(true);
+ manager_->SetView(&view_);
+ WaitForFrameLoad();
+ WaitForCoalescing();
+ manager_->AddRequest(&request1_);
+ manager_->AddRequest(&iframe_request_other_domain_);
+ manager_->AddRequest(&request2_);
+ base::MessageLoop::current()->RunUntilIdle();
+
+ EXPECT_FALSE(view_.shown_);
+}
+
+TEST_F(PermissionBubbleManagerTest, RequestsWithUserGesture) {
+ manager_->RequireUserGesture(true);
+ manager_->SetView(&view_);
+ WaitForFrameLoad();
+ WaitForCoalescing();
+ request1_.SetHasUserGesture();
+ manager_->AddRequest(&request1_);
+ manager_->AddRequest(&iframe_request_other_domain_);
+ manager_->AddRequest(&request2_);
+ base::MessageLoop::current()->RunUntilIdle();
+
+ EXPECT_TRUE(view_.shown_);
+}
+
+TEST_F(PermissionBubbleManagerTest, RequestsDontNeedUserGesture) {
+ manager_->SetView(&view_);
+ WaitForFrameLoad();
+ WaitForCoalescing();
+ manager_->AddRequest(&request1_);
+ manager_->AddRequest(&iframe_request_other_domain_);
+ manager_->AddRequest(&request2_);
+ base::MessageLoop::current()->RunUntilIdle();
+
+ EXPECT_TRUE(view_.shown_);
+}
+

Powered by Google App Engine
This is Rietveld 408576698