Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3586)

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_manager.cc

Issue 839063003: By default, remove user gesture restriction from permission bubbles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove debugging statement Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/permission_bubble_manager.cc
diff --git a/chrome/browser/ui/website_settings/permission_bubble_manager.cc b/chrome/browser/ui/website_settings/permission_bubble_manager.cc
index 083e56df2b59c86b095fdc26d5e5456e670a3807..4a64dae46e13957d0ae08ca686879b4213d6a598 100644
--- a/chrome/browser/ui/website_settings/permission_bubble_manager.cc
+++ b/chrome/browser/ui/website_settings/permission_bubble_manager.cc
@@ -67,6 +67,7 @@ bool PermissionBubbleManager::Enabled() {
PermissionBubbleManager::PermissionBubbleManager(
content::WebContents* web_contents)
: content::WebContentsObserver(web_contents),
+ require_user_gesture_(false),
bubble_showing_(false),
view_(NULL),
request_url_has_loaded_(false),
@@ -135,7 +136,7 @@ void PermissionBubbleManager::AddRequest(PermissionBubbleRequest* request) {
queued_frame_requests_.push_back(request);
}
- if (request->HasUserGesture())
+ if (!require_user_gesture_ || request->HasUserGesture())
ScheduleShowBubble();
}
@@ -202,6 +203,10 @@ void PermissionBubbleManager::SetView(PermissionBubbleView* view) {
TriggerShowBubble();
}
+void PermissionBubbleManager::RequireUserGesture(bool required) {
+ require_user_gesture_ = required;
+}
+
void PermissionBubbleManager::DocumentOnLoadCompletedInMainFrame() {
request_url_has_loaded_ = true;
// This is scheduled because while all calls to the browser have been

Powered by Google App Engine
This is Rietveld 408576698