By default, remove user gesture restriction from permission bubbles

By default, remove user gesture restriction from permission bubbles

BUG=446607
Committed: https://crrev.com/299f86652f2704e18b1af4497990c5e7e9bcae33
Cr-Commit-Position: refs/heads/master@{#311481}

[felt, 2015-01-08 22:00:29]

felt@chromium.org changed reviewers:
+ groby@chromium.org

[felt, 2015-01-08 22:00:29]

groby@, PTAL

[groby-ooo-7-16, 2015-01-08 23:20:27]

Does what it says on the box, but why is the user gesture requirement global?
And will that ever change at runtime, or is that requirement really set at
compile time?

[felt, 2015-01-09 01:50:10]

On 2015/01/08 23:20:27, groby wrote:
> Does what it says on the box, but why is the user gesture requirement global?

We can't set the requirement per-consumer. Otherwise you end up with the
following situation:

1) permission request with [ no gesture, consumer asks for gesture requirement ]
2) permission request with [ no gesture, consumer does not ask for gesture
requirement ]
3) permission request with [ gesture ]

When is the first request shown? With (2) or (3)? Going purely on a per-request
basis, it would seem that we would need to save (1) until (3) comes around. IMO
that will unnecessarily complicate the queueing code for a marginal benefit...
plus I suspect it will make the policy seem like black magic to developers.

> And will that ever change at runtime, or is that requirement really set at
> compile time?

I made it changeable at runtime (instead of a constant) so that the tests could
test both ways (in case we want to re-enable the gesture requirement later, we
wouldn't want it to break in the interim). But if you think I should completely
gut the gesture-based queueing logic, I could.

[groby-ooo-7-16, 2015-01-09 16:58:16]

Let's keep it configurable for now - I just wanted to make sure I understood the
why behind it.

LGTM

[felt, 2015-01-09 17:00:04]

felt@chromium.org changed reviewers:
+ markusheintz@chromium.org

[felt, 2015-01-09 17:00:18]

markus, can you please review when you're back? thanks.

[felt, 2015-01-12 16:46:00]

markus, friendly post-vacation ping :)

[markusheintz_, 2015-01-14 07:50:56]

On 2015/01/12 16:46:00, felt wrote:
> markus, friendly post-vacation ping :)

LGTM

[felt, 2015-01-14 15:13:34]

The CQ bit was checked by felt@chromium.org

[commit-bot: I haz the power, 2015-01-14 15:14:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/839063003/20001

[commit-bot: I haz the power, 2015-01-14 15:46:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-14 15:47:59]

Patchset 2 (id:??) landed as
https://crrev.com/299f86652f2704e18b1af4497990c5e7e9bcae33
Cr-Commit-Position: refs/heads/master@{#311481}