Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 839053004: src: fix build on freebsd (Closed)

Created:
5 years, 11 months ago by indutny
Modified:
5 years, 11 months ago
Reviewers:
danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

src: fix build on freebsd BUG= R=danno Committed: https://crrev.com/e8b9f2d70b8bfd24a69a5a4390a26e8ed945d8e0 Cr-Commit-Position: refs/heads/master@{#26057}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/base/platform/platform-freebsd.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/base/platform/platform-posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/preparser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/unique.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (1 generated)
indutny
Right now build on FreeBSD fails with: In file included from ../deps/v8/src/api.cc:16: In file included ...
5 years, 11 months ago (2015-01-13 17:54:06 UTC) #1
danno
lgtm
5 years, 11 months ago (2015-01-14 14:07:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839053004/1
5 years, 11 months ago (2015-01-14 14:08:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 14:35:30 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e8b9f2d70b8bfd24a69a5a4390a26e8ed945d8e0 Cr-Commit-Position: refs/heads/master@{#26057}
5 years, 11 months ago (2015-01-14 14:35:53 UTC) #6
indutny
On 2015/01/14 14:35:30, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) Thank ...
5 years, 11 months ago (2015-01-14 14:35:59 UTC) #7
indutny
Daniel, Could this be backported to 4.1 branch? We are currently floating similar patch on ...
5 years, 11 months ago (2015-01-18 12:12:32 UTC) #8
danno
5 years, 11 months ago (2015-01-19 08:00:43 UTC) #9
Message was sent while issue was closed.
Sure, we can port this back, we need to get Canary coverage, first, though.

Powered by Google App Engine
This is Rietveld 408576698