Cast: Add capabity to parse receiver and sender log messages over RTCP.

Cast: Add capabity to parse receiver and sender log messages over RTCP.

This cl contains the parsing of the RTCP packets containing the log
messages. The callbacks sending the parsed data into our log system is
not wired up; that will be done in a seperate cl.
Additionally the sender does not generate these type of messages yet.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236920

[pwestin, 2013-11-22 18:54:59]

pleas review

[mikhal, 2013-11-22 21:33:18]

lgtm + a few nits

https://chromiumcodereview.appspot.com/83903002/diff/80001/media/cast/logging...
File media/cast/logging/logging_defines.h (right):

https://chromiumcodereview.appspot.com/83903002/diff/80001/media/cast/logging...
media/cast/logging/logging_defines.h:20: kUnknown,
should also be added in the .cc

https://chromiumcodereview.appspot.com/83903002/diff/80001/media/cast/rtcp/rt...
File media/cast/rtcp/rtcp.cc (right):

https://chromiumcodereview.appspot.com/83903002/diff/80001/media/cast/rtcp/rt...
media/cast/rtcp/rtcp.cc:56: : rtp_timestamp(timestamp) {}
rtp_timestamp_

https://chromiumcodereview.appspot.com/83903002/diff/80001/media/cast/rtcp/rt...
File media/cast/rtcp/rtcp_defines.h (right):

https://chromiumcodereview.appspot.com/83903002/diff/80001/media/cast/rtcp/rt...
media/cast/rtcp/rtcp_defines.h:60: uint32 rtp_timestamp;
underscore after member's names

https://chromiumcodereview.appspot.com/83903002/diff/80001/media/cast/rtcp/rt...
File media/cast/rtcp/rtcp_utility.h (right):

https://chromiumcodereview.appspot.com/83903002/diff/80001/media/cast/rtcp/rt...
media/cast/rtcp/rtcp_utility.h:217: // Application specific .
move .

https://chromiumcodereview.appspot.com/83903002/diff/80001/media/cast/rtcp/te...
File media/cast/rtcp/test_rtcp_packet_builder.cc (right):

https://chromiumcodereview.appspot.com/83903002/diff/80001/media/cast/rtcp/te...
media/cast/rtcp/test_rtcp_packet_builder.cc:248: uint8 event_id, uint16
event_timesamp_delta) {
align

[pwestin, 2013-11-22 22:50:32]

Fixed nits

https://codereview.chromium.org/83903002/diff/80001/media/cast/logging/loggin...
File media/cast/logging/logging_defines.h (right):

https://codereview.chromium.org/83903002/diff/80001/media/cast/logging/loggin...
media/cast/logging/logging_defines.h:20: kUnknown,
On 2013/11/22 21:33:18, mikhal wrote:
> should also be added in the .cc

Done.

https://codereview.chromium.org/83903002/diff/80001/media/cast/rtcp/rtcp.cc
File media/cast/rtcp/rtcp.cc (right):

https://codereview.chromium.org/83903002/diff/80001/media/cast/rtcp/rtcp.cc#n...
media/cast/rtcp/rtcp.cc:56: : rtp_timestamp(timestamp) {}
On 2013/11/22 21:33:18, mikhal wrote:
> rtp_timestamp_

Done.

https://codereview.chromium.org/83903002/diff/80001/media/cast/rtcp/rtcp_defi...
File media/cast/rtcp/rtcp_defines.h (right):

https://codereview.chromium.org/83903002/diff/80001/media/cast/rtcp/rtcp_defi...
media/cast/rtcp/rtcp_defines.h:60: uint32 rtp_timestamp;
On 2013/11/22 21:33:18, mikhal wrote:
> underscore after member's names

Done.

https://codereview.chromium.org/83903002/diff/80001/media/cast/rtcp/rtcp_util...
File media/cast/rtcp/rtcp_utility.h (right):

https://codereview.chromium.org/83903002/diff/80001/media/cast/rtcp/rtcp_util...
media/cast/rtcp/rtcp_utility.h:217: // Application specific .
On 2013/11/22 21:33:18, mikhal wrote:
> move .

Done.

https://codereview.chromium.org/83903002/diff/80001/media/cast/rtcp/test_rtcp...
File media/cast/rtcp/test_rtcp_packet_builder.cc (right):

https://codereview.chromium.org/83903002/diff/80001/media/cast/rtcp/test_rtcp...
media/cast/rtcp/test_rtcp_packet_builder.cc:248: uint8 event_id, uint16
event_timesamp_delta) {
On 2013/11/22 21:33:18, mikhal wrote:
> align

Not sure what you want me to align; it is indented 4 since it belong to the
function header.

[pwestin, 2013-11-22 22:54:07]

added mikhal @ chromium

[mikhal1, 2013-11-22 22:55:48]

lgtm

[commit-bot: I haz the power, 2013-11-22 22:56:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pwestin@google.com/83903002/150001

[commit-bot: I haz the power, 2013-11-22 22:56:54]

Failed to apply patch for media/cast/logging/logging_defines.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file media/cast/logging/logging_defines.cc
  Hunk #1 FAILED at 11.
  1 out of 1 hunk FAILED -- saving rejects to file
media/cast/logging/logging_defines.cc.rej

Patch:       media/cast/logging/logging_defines.cc
Index: media/cast/logging/logging_defines.cc
diff --git a/media/cast/logging/logging_defines.cc
b/media/cast/logging/logging_defines.cc
index
3f502f9eaabaa6a2630b1d9a101382f219f38a9e..f0e02a95159df9754cc79841409369bccb974356
100644
--- a/media/cast/logging/logging_defines.cc
+++ b/media/cast/logging/logging_defines.cc
@@ -11,6 +11,10 @@ namespace cast {
 
 std::string CastLoggingToString(CastLoggingEvent event) {
   switch (event) {
+    case(kUnknown):
+      // Can happen if the sender and receiver of RTCP log messages are not
+      // aligned.
+      return "Unknown";
     case(kRtt):
       return "Rtt";
     case(kPacketLoss):

[commit-bot: I haz the power, 2013-11-23 00:12:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pwestin@google.com/83903002/220001

[commit-bot: I haz the power, 2013-11-23 01:59:06]

Change committed as 236920