Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3625)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.h

Issue 839023003: Log password manager UI state changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test crashes Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_ui_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
index a717dcce701c433b6bc81478de116b4cf19e2817..5a1838e20073936b25a9ff88a0fc35e7f22e60a7 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
@@ -145,6 +145,9 @@ class ManagePasswordsUIController
const content::FrameNavigateParams& params) override;
void WasHidden() override;
+ // Sets |state_|. Protected so we can manipulate the value in tests.
+ void SetState(password_manager::ui::State state);
+
// We create copies of PasswordForm objects that come in with unclear lifetime
// and store them in this vector as well as in |password_form_map_| to ensure
// that we destroy them correctly. If |new_password_forms_| gets cleared then
@@ -156,10 +159,6 @@ class ManagePasswordsUIController
// ManagePasswordsUIControllerMock.
autofill::ConstPasswordFormMap password_form_map_;
- // The current state of the password manager. Protected so we can manipulate
- // the value in tests.
- password_manager::ui::State state_;
-
private:
friend class content::WebContentsUserData<ManagePasswordsUIController>;
@@ -170,6 +169,9 @@ class ManagePasswordsUIController
// content::WebContentsObserver:
void WebContentsDestroyed() override;
+ // The current state of the password manager UI.
+ password_manager::ui::State state_;
+
// Used to measure the amount of time on a page; if it's less than some
// reasonable limit, then don't close the bubble upon navigation. We create
// (and destroy) the timer in DidNavigateMainFrame.
« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_ui_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698