Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 839013005: Move ForkWithFlags from process* to launch*. (Closed)

Created:
5 years, 11 months ago by rickyz (no longer on Chrome)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ForkWithFlags from process* to launch*. As suggested at https://codereview.chromium.org/840893003/. BUG= Committed: https://crrev.com/a2f6d748a24879d0bdd824e2020d0938d103c8f9 Cr-Commit-Position: refs/heads/master@{#312465}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move tests to process_util_unittest.cc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -229 lines) Patch
M base/process/launch.h View 1 chunk +19 lines, -0 lines 0 comments Download
M base/process/launch_posix.cc View 4 chunks +94 lines, -0 lines 0 comments Download
M base/process/process.h View 1 chunk +0 lines, -19 lines 0 comments Download
M base/process/process_linux.cc View 3 chunks +0 lines, -92 lines 0 comments Download
M base/process/process_unittest.cc View 1 2 chunks +0 lines, -116 lines 0 comments Download
M base/process/process_util_unittest.cc View 1 3 chunks +110 lines, -0 lines 0 comments Download
M content/zygote/zygote_linux.cc View 2 chunks +3 lines, -1 line 0 comments Download
M sandbox/linux/services/credentials.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
rickyz (no longer on Chrome)
Here's that change to move ForkWithFlags (for the 2nd time :-))
5 years, 11 months ago (2015-01-20 23:48:34 UTC) #2
jln (very slow on Chromium)
lgtm but deferring to rvargas who refactored this area lately.
5 years, 11 months ago (2015-01-21 01:00:01 UTC) #4
rvargas (doing something else)
https://chromiumcodereview.appspot.com/839013005/diff/1/base/process/process_unittest.cc File base/process/process_unittest.cc (right): https://chromiumcodereview.appspot.com/839013005/diff/1/base/process/process_unittest.cc#newcode12 base/process/process_unittest.cc:12: #include "base/process/launch.h" For some reason (probably just history), launch, ...
5 years, 11 months ago (2015-01-21 01:10:08 UTC) #5
rickyz (no longer on Chrome)
https://codereview.chromium.org/839013005/diff/1/base/process/process_unittest.cc File base/process/process_unittest.cc (right): https://codereview.chromium.org/839013005/diff/1/base/process/process_unittest.cc#newcode12 base/process/process_unittest.cc:12: #include "base/process/launch.h" On 2015/01/21 01:10:08, rvargas wrote: > For ...
5 years, 11 months ago (2015-01-21 18:46:23 UTC) #6
rvargas (doing something else)
RBSTMP LGTM. Thanks.
5 years, 11 months ago (2015-01-21 19:02:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839013005/20001
5 years, 11 months ago (2015-01-21 20:52:23 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-21 21:58:06 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 21:59:04 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a2f6d748a24879d0bdd824e2020d0938d103c8f9
Cr-Commit-Position: refs/heads/master@{#312465}

Powered by Google App Engine
This is Rietveld 408576698