Issue 8390012: Merge 98263 - <svg> fails to use explicit width and height inside <html> inside IFRAME

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8390012: Merge 98263 - <svg> fails to use explicit width and height inside <html> inside IFRAME (Closed)

Created:
9 years, 1 month ago by leviw_travelin_and_unemployed

Modified:
9 years, 1 month ago

Reviewers:
leviw_travelin_and_unemployed

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/912/

Visibility:
Public.

Description

Merge 98263 - <svg> fails to use explicit width and height inside <html> inside IFRAME https://bugs.webkit.org/show_bug.cgi?id=64823 Reviewed by Nikolas Zimmermann. Source/WebCore: Checking that embedded SVG is in an SVG document before negotiating size with the host document. Test: svg/as-object/svg-embedded-in-html-in-iframe.html * rendering/svg/RenderSVGRoot.cpp: (WebCore::isEmbeddedThroughFrameContainingSVGDocument): (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): LayoutTests: Fixing a bug where SVG negotiated size when embedded in html inside an iframe. * platform/chromium/test_expectations.txt: Will update with results on other platforms. * platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added. * platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added. * svg/as-object/svg-embedded-in-html-in-iframe.html: Added. TBR=leviw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98370

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -3 lines)			Patch
M	LayoutTests/platform/chromium/test_expectations.txt	View	1 chunk	+28 lines, -0 lines	0 comments	Download
A +	LayoutTests/platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/svg/as-object/svg-embedded-in-html-in-iframe.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/WebCore/rendering/svg/RenderSVGRoot.cpp	View	3 chunks	+13 lines, -6 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages