Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 838993002: Gallery: Split GalleryDataModel from gallery.js. (Closed)

Created:
5 years, 11 months ago by hirono
Modified:
5 years, 11 months ago
Reviewers:
yawano
CC:
chromium-reviews, nkostylev+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gallery: Split GalleryDataModel from gallery.js. The CL moves lines of GalleryDataModel from gallery.js to gallery_data_model.js. Also it adds a unittest for saving items. BUG=439898 TEST=GalleryJsTest.GalleryDataModelTest Committed: https://crrev.com/fa12ca02a4a47b9321b46a1ac64fc57a2220d387 Cr-Commit-Position: refs/heads/master@{#310685}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Fix the year. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -149 lines) Patch
M chrome/browser/chromeos/file_manager/gallery_jstest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/file_manager/gallery/gallery.html View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/gallery/js/compiled_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/gallery/js/gallery.js View 1 chunk +0 lines, -144 lines 0 comments Download
A ui/file_manager/gallery/js/gallery_data_model.js View 1 1 chunk +148 lines, -0 lines 0 comments Download
A + ui/file_manager/gallery/js/gallery_data_model_unittest.html View 1 1 chunk +8 lines, -5 lines 0 comments Download
A ui/file_manager/gallery/js/gallery_data_model_unittest.js View 1 2 1 chunk +58 lines, -0 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_scripts.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hirono
@yawano - PTAL? The GalleryDataModel itself is not changed except for the constructor become to ...
5 years, 11 months ago (2015-01-08 11:27:50 UTC) #2
yawano
lgtm with nit. Thank you! https://codereview.chromium.org/838993002/diff/20001/ui/file_manager/gallery/js/gallery_data_model_unittest.js File ui/file_manager/gallery/js/gallery_data_model_unittest.js (right): https://codereview.chromium.org/838993002/diff/20001/ui/file_manager/gallery/js/gallery_data_model_unittest.js#newcode1 ui/file_manager/gallery/js/gallery_data_model_unittest.js:1: // Copyright 2014 The ...
5 years, 11 months ago (2015-01-09 01:08:58 UTC) #3
hirono
Thanks! https://codereview.chromium.org/838993002/diff/20001/ui/file_manager/gallery/js/gallery_data_model_unittest.js File ui/file_manager/gallery/js/gallery_data_model_unittest.js (right): https://codereview.chromium.org/838993002/diff/20001/ui/file_manager/gallery/js/gallery_data_model_unittest.js#newcode1 ui/file_manager/gallery/js/gallery_data_model_unittest.js:1: // Copyright 2014 The Chromium Authors. All rights ...
5 years, 11 months ago (2015-01-09 01:12:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838993002/40001
5 years, 11 months ago (2015-01-09 01:14:08 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-09 02:42:21 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 02:43:06 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/fa12ca02a4a47b9321b46a1ac64fc57a2220d387
Cr-Commit-Position: refs/heads/master@{#310685}

Powered by Google App Engine
This is Rietveld 408576698