Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Issue 838983002: Revert of Add d8 target to the GN build. (Closed)

Created:
5 years, 11 months ago by Yang
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add d8 target to the GN build. (patchset #2 id:40001 of https://codereview.chromium.org/834113005/) Reason for revert: V8 roll fails due to this change. (see https://codereview.chromium.org/843673003/) Original issue's description: > Add d8 target to the GN build. > > Also formats the rest of the file with "gn format". This accounts for all the changes except for the "d8" target additions. > > Committed: https://crrev.com/36383f08c1f692ea797d54a27d7c6b3d3d53b440 > Cr-Commit-Position: refs/heads/master@{#25984} TBR=jochen@chromium.org,machenbach@chromium.org,brettw@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/ef50fdfdb05e1a3a3822962f5235b804218a5f4e Cr-Commit-Position: refs/heads/master@{#25985}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -210 lines) Patch
M BUILD.gn View 22 chunks +150 lines, -210 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
Created Revert of Add d8 target to the GN build.
5 years, 11 months ago (2015-01-08 08:37:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838983002/1
5 years, 11 months ago (2015-01-08 08:38:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-08 08:38:21 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ef50fdfdb05e1a3a3822962f5235b804218a5f4e Cr-Commit-Position: refs/heads/master@{#25985}
5 years, 11 months ago (2015-01-08 08:38:34 UTC) #4
Yang
5 years, 11 months ago (2015-01-08 13:21:03 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/833563004/ by yangguo@chromium.org.

The reason for reverting is: Relanding because this is not actually blocking the
roll..

Powered by Google App Engine
This is Rietveld 408576698