Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 838933003: roll gtest 700:704 (Closed)

Created:
5 years, 11 months ago by Nico
Modified:
5 years, 11 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

roll gtest 700:704 Include fixes: https://code.google.com/p/googletest/source/detail?r=701 MinGW specific: https://code.google.com/p/googletest/source/detail?r=702 The reason I want this: Fixing compiling the gmock header in .mm files with new clang revisions that have clang r220714: https://code.google.com/p/googletest/source/detail?r=703 https://code.google.com/p/googletest/source/detail?r=704 BUG=444089 TBR=hans@chromium.org Committed: https://crrev.com/257cca71d1c9328010662bcfa3436ebaed93786c Cr-Commit-Position: refs/heads/master@{#311518}

Patch Set 1 #

Patch Set 2 : 704 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Nico
5 years, 11 months ago (2015-01-08 05:44:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838933003/1
5 years, 11 months ago (2015-01-08 05:45:16 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/46538)
5 years, 11 months ago (2015-01-08 06:22:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838933003/20001
5 years, 11 months ago (2015-01-14 16:36:31 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 18:27:18 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 18:28:30 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/257cca71d1c9328010662bcfa3436ebaed93786c
Cr-Commit-Position: refs/heads/master@{#311518}

Powered by Google App Engine
This is Rietveld 408576698