Source/core/loader/EmptyClients.h - Issue 838903002: Replicate sandbox flags for OOPIF (Blink part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/EmptyClients.h

Issue 838903002: Replicate sandbox flags for OOPIF (Blink part 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@iframe-sandbox-flags-part1

Patch Set: Remove old createLocalChild Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/loader/EmptyClients.h

diff --git a/Source/core/loader/EmptyClients.h b/Source/core/loader/EmptyClients.h

index c091aeb0a5be52143075f704ef5ad2ba77ee98d8..573acaca707620fa68f41991299eec0e51f32181 100644

--- a/Source/core/loader/EmptyClients.h

+++ b/Source/core/loader/EmptyClients.h

@@ -223,7 +223,7 @@ public:

virtual void didDetectXSS(const KURL&, bool) override { }

virtual void didDispatchPingLoader(const KURL&) override { }

virtual void selectorMatchChanged(const Vector<String>&, const Vector<String>&) override { }

- virtual PassRefPtrWillBeRawPtr<LocalFrame> createFrame(const KURL&, const AtomicString&, HTMLFrameOwnerElement*, ContentSecurityPolicyDisposition) override;

+ virtual PassRefPtrWillBeRawPtr<LocalFrame> createFrame(const KURL&, const AtomicString&, HTMLFrameOwnerElement*, ContentSecurityPolicyDisposition, SandboxFlags) override;

virtual PassOwnPtrWillBeRawPtr<PluginPlaceholder> createPluginPlaceholder(Document&, const KURL&, const Vector<String>& paramNames, const Vector<String>& paramValues, const String& mimeType, bool loadManually) override;

virtual PassRefPtrWillBeRawPtr<Widget> createPlugin(HTMLPlugInElement*, const KURL&, const Vector<String>&, const Vector<String>&, const String&, bool, DetachedPluginPolicy) override;

virtual bool canCreatePluginWithoutRenderer(const String& mimeType) const override { return false; }

« no previous file with comments | « Source/core/html/HTMLFrameOwnerElement.cpp ('k') | Source/core/loader/EmptyClients.cpp » ('j') | Source/core/loader/FrameLoadRequest.h » ('J')