Source/core/loader/FrameLoader.cpp - Issue 838903002: Replicate sandbox flags for OOPIF (Blink part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/FrameLoader.cpp

Issue 838903002: Replicate sandbox flags for OOPIF (Blink part 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@iframe-sandbox-flags-part1

Patch Set: Simplify the plumbing by making HTMLFrameOwnerElement::sandboxFlags() public Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/loader/FrameLoader.cpp

diff --git a/Source/core/loader/FrameLoader.cpp b/Source/core/loader/FrameLoader.cpp

index d93f1b81c51cecd8a2f4031ea20e3b04611e3fad..9d2d80dbf3b19ab575a45943e6769adf02da6080 100644

--- a/Source/core/loader/FrameLoader.cpp

+++ b/Source/core/loader/FrameLoader.cpp

@@ -1377,7 +1377,6 @@ void FrameLoader::dispatchDidClearWindowObjectInMainWorld()

SandboxFlags FrameLoader::effectiveSandboxFlags() const

{

SandboxFlags flags = m_forcedSandboxFlags;

- // FIXME: We need a way to propagate sandbox flags to out-of-process frames.

if (FrameOwner* frameOwner = m_frame->owner())

flags |= frameOwner->sandboxFlags();

return flags;

« Source/core/html/HTMLFrameOwnerElement.h ('K') | « Source/core/html/HTMLFrameOwnerElement.h ('k') | Source/web/WebLocalFrameImpl.cpp » ('j') | Source/web/WebRemoteFrameImpl.cpp » ('J')