Replicate sandbox flags for OOPIF (Blink part 2)

Source/core/loader/FrameLoadRequest.h

 /*
  * Copyright (C) 2003, 2006, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 27 matching lines @@
 
 struct FrameLoadRequest {
     STACK_ALLOCATED();
 public:
     explicit FrameLoadRequest(Document* originDocument)
         : m_originDocument(originDocument)
         , m_lockBackForwardList(false)
         , m_clientRedirect(NotClientRedirect)
         , m_shouldSendReferrer(MaybeSendReferrer)
         , m_shouldCheckMainWorldContentSecurityPolicy(CheckContentSecurityPolicy)
+        , m_sandboxFlags(SandboxNone)
     {
     }
 
     FrameLoadRequest(Document* originDocument, const ResourceRequest& resourceRequest)
         : m_originDocument(originDocument)
         , m_resourceRequest(resourceRequest)
         , m_lockBackForwardList(false)
         , m_clientRedirect(NotClientRedirect)
         , m_shouldSendReferrer(MaybeSendReferrer)
         , m_shouldCheckMainWorldContentSecurityPolicy(CheckContentSecurityPolicy)
+        , m_sandboxFlags(SandboxNone)
     {
     }
 
     FrameLoadRequest(Document* originDocument, const ResourceRequest& resourceRequest, const AtomicString& frameName)
         : m_originDocument(originDocument)
         , m_resourceRequest(resourceRequest)
         , m_frameName(frameName)
         , m_lockBackForwardList(false)
         , m_clientRedirect(NotClientRedirect)
         , m_shouldSendReferrer(MaybeSendReferrer)
         , m_shouldCheckMainWorldContentSecurityPolicy(CheckContentSecurityPolicy)
+        , m_sandboxFlags(SandboxNone)
     {
     }
 
     FrameLoadRequest(Document* originDocument, const ResourceRequest& resourceRequest, const AtomicString& frameName, ContentSecurityPolicyDisposition shouldCheckMainWorldContentSecurityPolicy)
         : m_originDocument(originDocument)
         , m_resourceRequest(resourceRequest)
         , m_frameName(frameName)
         , m_lockBackForwardList(false)
         , m_clientRedirect(NotClientRedirect)
         , m_shouldSendReferrer(MaybeSendReferrer)
         , m_shouldCheckMainWorldContentSecurityPolicy(shouldCheckMainWorldContentSecurityPolicy)
+        , m_sandboxFlags(SandboxNone)

[dcheng, 2015/01/16 19:11:19]

We should probably consider delegated constructors =)

[alexmos, 2015/01/17 02:54:42]

Oh, neat, didn't realize these are allowed. :)  I can give this a shot after we
hear from Nate about the other question, since I may end up not modifying this.

     {
     }
 
+    FrameLoadRequest(Document* originDocument, const ResourceRequest& resourceRequest, const AtomicString& frameName, ContentSecurityPolicyDisposition shouldCheckMainWorldContentSecurityPolicy, SandboxFlags sandboxFlags)
+        : m_originDocument(originDocument)
+        , m_resourceRequest(resourceRequest)
+        , m_frameName(frameName)
+        , m_lockBackForwardList(false)
+        , m_clientRedirect(NotClientRedirect)
+        , m_shouldSendReferrer(MaybeSendReferrer)
+        , m_shouldCheckMainWorldContentSecurityPolicy(shouldCheckMainWorldContentSecurityPolicy)
+        , m_sandboxFlags(sandboxFlags)
+    {
+    }
+
     FrameLoadRequest(Document* originDocument, const ResourceRequest& resourceRequest, const SubstituteData& substituteData)
         : m_originDocument(originDocument)
         , m_resourceRequest(resourceRequest)
         , m_substituteData(substituteData)
         , m_lockBackForwardList(false)
         , m_clientRedirect(NotClientRedirect)
         , m_shouldSendReferrer(MaybeSendReferrer)
         , m_shouldCheckMainWorldContentSecurityPolicy(CheckContentSecurityPolicy)
+        , m_sandboxFlags(SandboxNone)
     {
     }
 
     Document* originDocument() const { return m_originDocument.get(); }
 
     ResourceRequest& resourceRequest() { return m_resourceRequest; }
     const ResourceRequest& resourceRequest() const { return m_resourceRequest; }
 
     const AtomicString& frameName() const { return m_frameName; }
     void setFrameName(const AtomicString& frameName) { m_frameName = frameName; }
@@ skipping 10 matching lines @@
     void setTriggeringEvent(PassRefPtrWillBeRawPtr<Event> triggeringEvent) { m_triggeringEvent = triggeringEvent; }
 
     FormState* formState() const { return m_formState.get(); }
     void setFormState(PassRefPtrWillBeRawPtr<FormState> formState) { m_formState = formState; }
 
     ShouldSendReferrer shouldSendReferrer() const { return m_shouldSendReferrer; }
     void setShouldSendReferrer(ShouldSendReferrer shouldSendReferrer) { m_shouldSendReferrer = shouldSendReferrer; }
 
     ContentSecurityPolicyDisposition shouldCheckMainWorldContentSecurityPolicy() const { return m_shouldCheckMainWorldContentSecurityPolicy; }
 
+    const SandboxFlags& sandboxFlags() const { return m_sandboxFlags; }

[dcheng, 2015/01/16 19:11:19]

Are you intentionally returning a reference here? Many accessors for POD types
like this tend to return by value.

[alexmos, 2015/01/17 02:54:42]

Unintentional, fixed.

+
 private:
     RefPtrWillBeMember<Document> m_originDocument;
     ResourceRequest m_resourceRequest;
     AtomicString m_frameName;
     SubstituteData m_substituteData;
     bool m_lockBackForwardList;
     ClientRedirectPolicy m_clientRedirect;
     RefPtrWillBeMember<Event> m_triggeringEvent;
     RefPtrWillBeMember<FormState> m_formState;
     ShouldSendReferrer m_shouldSendReferrer;
     ContentSecurityPolicyDisposition m_shouldCheckMainWorldContentSecurityPolicy;
+    SandboxFlags m_sandboxFlags;
 };
 
 }
 
 #endif // FrameLoadRequest_h