Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 838863002: Remove SelectorChecker::ContextFlags. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove SelectorChecker::ContextFlags. We don't need the flags, we can just use an explicit check for :host(). R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/993f1319a10814f57837ba7840f8eb9c2fb90045

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -27 lines) Patch
M sky/engine/core/css/ElementRuleCollector.h View 1 chunk +5 lines, -5 lines 0 comments Download
M sky/engine/core/css/ElementRuleCollector.cpp View 3 chunks +8 lines, -9 lines 0 comments Download
M sky/engine/core/css/SelectorChecker.h View 3 chunks +0 lines, -7 lines 0 comments Download
M sky/engine/core/css/SelectorChecker.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M sky/engine/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
5 years, 11 months ago (2015-01-07 19:49:31 UTC) #2
ojan
lgtm
5 years, 11 months ago (2015-01-07 19:52:35 UTC) #3
esprehn
5 years, 11 months ago (2015-01-07 19:57:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
993f1319a10814f57837ba7840f8eb9c2fb90045 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698