Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 838793004: Windows file associations: Search for shim in Chrome version directory. (Closed)

Created:
5 years, 11 months ago by Matt Giuca
Modified:
5 years, 11 months ago
Reviewers:
jackhou1
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Windows file associations: Search for shim in Chrome version directory. Previously, would search for app_shim.exe in the Chrome application directory, for example: C:\Program Files\Google\Chrome\Application Now searches in the Chrome version directory, for example: C:\Program Files\Google\Chrome\Application\42.0.2277.0 which is where all version-specific files should be stored. Note: The installer does not currently place app_shim.exe anywhere, so we do not need to update its location. Users who have manually copied app_shim.exe into the application directory will need to move it into the version directory after this change. Also gives a better error message if app_shim.exe is not found. BUG=430760 Committed: https://crrev.com/8a3b08cdba3c4ea2afce430f24c356e3e08666de Cr-Commit-Position: refs/heads/master@{#311800}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M chrome/browser/web_applications/web_app_win.cc View 1 chunk +11 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Matt Giuca
5 years, 11 months ago (2015-01-15 23:15:29 UTC) #2
jackhou1
lgtm
5 years, 11 months ago (2015-01-15 23:19:49 UTC) #3
Matt Giuca
What service!
5 years, 11 months ago (2015-01-15 23:23:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838793004/1
5 years, 11 months ago (2015-01-15 23:23:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 00:55:45 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 00:56:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a3b08cdba3c4ea2afce430f24c356e3e08666de
Cr-Commit-Position: refs/heads/master@{#311800}

Powered by Google App Engine
This is Rietveld 408576698