Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3465)

Unified Diff: dart/tests/compiler/dart2js/package_root_test.dart

Issue 838773002: Throw ArgumentError if packageRoot is null. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/tests/compiler/dart2js/package_root_test.dart
diff --git a/dart/tests/compiler/dart2js/package_root_test.dart b/dart/tests/compiler/dart2js/package_root_test.dart
index 7a5cce3e8896151fc4646347a421f7e56d7b6186..93327b3f9a4b08cab8c314a51e2964f0cbb7bcb7 100644
--- a/dart/tests/compiler/dart2js/package_root_test.dart
+++ b/dart/tests/compiler/dart2js/package_root_test.dart
@@ -30,6 +30,7 @@ main() {}
void runCompiler(Uri main) {
Uri script = currentDirectory.resolveUri(Platform.script);
Uri libraryRoot = script.resolve('../../../sdk/');
+ Uri packageRoot = script.resolve('./packages/');
var provider = new MemorySourceFileProvider(MEMORY_SOURCE_FILES);
var handler = new FormattingDiagnosticHandler(provider);
@@ -53,15 +54,15 @@ void runCompiler(Uri main) {
outputProvider,
diagnosticHandler,
libraryRoot,
- null,
+ packageRoot,
[],
{});
asyncTest(() => compiler.run(main).then((_) {
Expect.equals(1, errors.length);
- Expect.equals("Cannot resolve 'package:foo/foo.dart'. "
- "Package root has not been set.",
- errors[0]);
+ Expect.isTrue(
+ errors[0].startsWith(
+ "Can't read 'package:foo/foo.dart' (Error reading "));
}));
}

Powered by Google App Engine
This is Rietveld 408576698