Throw ArgumentError if packageRoot is null.

dart/pkg/compiler/samples/jsonify/jsonify.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:io';
 import 'dart:convert';
 
 import 'dart:mirrors';
 
 import 'package:_internal/libraries.dart'
@@ skipping 28 matching lines @@
   handler = new FormattingDiagnosticHandler()
       ..throwOnError = true;
 
   outputUri =
       handler.provider.cwd.resolve(nativeToUriPath(arguments.first));
   output = new File(arguments.first).openSync(mode: FileMode.WRITE);
 
   Uri myLocation =
       handler.provider.cwd.resolveUri(Platform.script);
 
-  sdkRoot = myLocation.resolve(SDK_ROOT).resolve('../');
+  Uri packageRoot =
+      handler.provider.cwd.resolve(Platform.packageRoot);

[Johnni Winther, 2015/01/08 08:16:15]

You need to ensure that the URI path ends with a /

[Platform.packageRoot] is _not_ the resolved base Uri but just the user-provided
string.

[ahe, 2015/01/08 08:34:43]

This isn't a super user friendly tool. For example, on line 43, an error will be
thrown if [arguments] is empty. I would rather not clutter this code with
handling of exceptional cases. Also, it isn't necessary, this tool doesn't read
packages.

In addition, it is possible to provide a usable package root which doesn't end
with a slash. It probably makes sense for dart2js (a directly user facing tool)
to complain about absence of a trailing slash, but I'm not convinced it is the
right trade-off for more low-level tools.

I'm going to submit this as-is, but please let me know if you disagree with my
analysis. I can create a follow-up CL.

[Johnni Winther, 2015/01/08 09:40:42]

The problem is really with Platform.packageRoot which should have been a fully
resolved URI.

+
+  Uri libraryRoot = myLocation.resolve(SDK_ROOT);
+
+  sdkRoot = libraryRoot.resolve('../');
 
   // Get the names of public dart2js libraries.
   Iterable<String> names = LIBRARIES.keys.where(isPublicDart2jsLibrary);
 
   // Turn the names into uris by prepending dart: to them.
   List<Uri> uris = names.map((String name) => Uri.parse('dart:$name')).toList();
 
-  analyze(uris, myLocation.resolve(SDK_ROOT), null, handler.provider, handler)
+  analyze(uris, libraryRoot, packageRoot, handler.provider, handler)
       .then(jsonify);
 }
 
 jsonify(MirrorSystem mirrors) {
   var map = <String, String>{};
 
   mirrors.libraries.forEach((_, LibraryMirror library) {
     BackDoor.compilationUnitsOf(library).forEach((compilationUnit) {
       Uri uri = compilationUnit.uri;
       String filename = relativize(sdkRoot, uri, false);
@@ skipping 24 matching lines @@
 // This file is generated by jsonify.dart.
 
 library dart.sdk_sources;
 
 const Map<String, String> SDK_SOURCES = const <String, String>''');
     output.writeStringSync(JSON.encode(map).replaceAll(r'$', r'\$'));
     output.writeStringSync(';\n');
   }
   output.closeSync();
 }