Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 838753004: Re-enable always-on hotwording for m42 on supported hardware. (Closed)

Created:
5 years, 11 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, rlp+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable always-on hotwording for m42 on supported hardware. Revert "Remove hardware check that enables always-on hotwording." This reverts commit e014345eab81e39c48956f9dae0cc0c66e170f08. Committed: https://crrev.com/c953e3324bc7d16265d63a8bac6649eef17c3230 Cr-Commit-Position: refs/heads/master@{#313214}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/browser/search/hotword_service_factory.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Anand Mistry (off Chromium)
5 years, 11 months ago (2015-01-16 02:08:38 UTC) #2
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-16 02:20:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838753004/1
5 years, 11 months ago (2015-01-16 02:34:05 UTC) #5
Anand Mistry (off Chromium)
On 2015/01/16 02:34:05, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 11 months ago (2015-01-16 02:42:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838753004/1
5 years, 11 months ago (2015-01-27 02:14:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 03:09:07 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 03:10:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c953e3324bc7d16265d63a8bac6649eef17c3230
Cr-Commit-Position: refs/heads/master@{#313214}

Powered by Google App Engine
This is Rietveld 408576698