Install sdk extras packages using android to prompt for ToS.

build/get_sdk_extras_packages.py

+#!/usr/bin/env python
+# Copyright (c) 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# Declare this so we can execfile(DEPS), which uses Var function
+def Var(str):
+  return str
+
+def get_sdk_extras(hooks):

[navabi, 2015/01/07 03:25:38]

Need some comments here about how I am looking in the dictionary defined by the
DEPS file to find the hook with the name 'sdkextras', and from that taking the
list of arguments to the download_sdk_extras.py script (e.g.
google_google_play_services_21.0.zip) and from that determining the name of the
package (e.g. google play services).

The name will be used by sdk/tools/android update to install the corresponding
package.

[cjhopman, 2015/01/07 03:57:49]

What about maintaining the list of these packages in a separate (json?) file?
and then read that file for this step and pass it as an argument to
download_sdk_extras.py in DEPS?

You could try doing them as more structured data instead of just a zip path...
something like:

{
  'dir_name': 'google',
  'package': 'google_play_services',
  'version': '1.0.0',
  'zip': 'google_google_play_services_1.0.0.zip',
}

but I don't know if that would make these scripts and such any simpler or not.

[navabi, 2015/01/07 16:41:18]

That's a good suggestion, because I don't like that i have to do a 'python -c'
in the install-build-deps-android.sh just to get the package name. For that
reason, I'm thinking of just using a text file that is easily grep'able in bash
rather than a json file, which I will not know how to read from bash without
again doing a 'python -c' (which would at least be an easier 'python -c' command
than the one in this patch).

+  sdk_extras_lists = [hook['action'][2:] for hook in hooks
+                      if hook['name'] == 'sdkextras']
+  sdk_extras = [sdk_extra[sdk_extra.index('_')+1:
+                          sdk_extra.rindex('_')].replace('_', ' ')
+                          for sublst in sdk_extras_lists
+                            for sdk_extra in sublst]
+  for sdk_extra in sdk_extras:
+    print sdk_extra