Testcases for nameddests and navigate for PDF

chrome/browser/resources/pdf/pdf_extension_test.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/base_paths.h"
 #include "base/files/file_util.h"
 #include "base/path_service.h"
 #include "chrome/browser/extensions/component_loader.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ skipping 22 matching lines @@
     ExtensionApiTest::SetUpOnMainThread();
     ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
   }
 
 
   virtual void TearDownOnMainThread() override {
     ASSERT_TRUE(embedded_test_server()->ShutdownAndWaitUntilComplete());
     ExtensionApiTest::TearDownOnMainThread();
   }
 
-  void RunTestsInFile(std::string filename, std::string pdf_filename) {
+  void RunTestsInFile(std::string filename,
+                      std::string pdf_filename,
+                      std::string commonfile) {

[raymes, 2015/01/28 01:33:45]

Let's not pass this as a param. Instead let's just always load "test_util.js"
for every test that gets run.

[Deepak, 2015/01/28 05:57:23]

Done.

[Deepak, 2015/01/28 05:57:24]

Done.

     base::FilePath pdf_path;
     ASSERT_TRUE(PathService::Get(chrome::FILE_PDF_PLUGIN, &pdf_path));
     ASSERT_TRUE(
         content::PluginService::GetInstance()->GetRegisteredPpapiPluginInfo(
             pdf_path));
     ExtensionService* service = extensions::ExtensionSystem::Get(
         profile())->extension_service();
     service->component_loader()->Add(IDR_PDF_MANIFEST,
         base::FilePath(FILE_PATH_LITERAL("pdf")));
     const extensions::Extension* extension =
@@ skipping 12 matching lines @@
         url.spec());
     ui_test_utils::NavigateToURL(browser(), extension_url);
     content::WebContents* contents =
         browser()->tab_strip_model()->GetActiveWebContents();
     content::WaitForLoadStop(contents);
 
     base::FilePath test_data_dir;
     PathService::Get(base::DIR_SOURCE_ROOT, &test_data_dir);
     test_data_dir = test_data_dir.Append(
         FILE_PATH_LITERAL("chrome/test/data/pdf"));
-    test_data_dir = test_data_dir.AppendASCII(filename);
+
+    base::FilePath file_test_data_dir = test_data_dir.AppendASCII(filename);
 
     std::string test_js;
-    ASSERT_TRUE(base::ReadFileToString(test_data_dir, &test_js));
+    ASSERT_TRUE(base::ReadFileToString(file_test_data_dir, &test_js));
+
+    if (!commonfile.empty()) {
+      std::string test_common_js;
+      test_data_dir = test_data_dir.AppendASCII(commonfile);
+      ASSERT_TRUE(base::ReadFileToString(test_data_dir, &test_common_js));
+      test_js.append(test_common_js);
+    }
+
     ASSERT_TRUE(content::ExecuteScript(contents, test_js));
 
     if (!catcher.GetNextResult())
       FAIL() << catcher.message();
   }
 };
 
 IN_PROC_BROWSER_TEST_F(PDFExtensionTest, Basic) {
-  RunTestsInFile("basic_test.js", "test.pdf");
+  RunTestsInFile("basic_test.js", "test.pdf", "");
 }
 
 IN_PROC_BROWSER_TEST_F(PDFExtensionTest, BasicPlugin) {
-  RunTestsInFile("basic_plugin_test.js", "test.pdf");
+  RunTestsInFile("basic_plugin_test.js", "test.pdf", "");
 }
 
 IN_PROC_BROWSER_TEST_F(PDFExtensionTest, Viewport) {
-  RunTestsInFile("viewport_test.js", "test.pdf");
+  RunTestsInFile("viewport_test.js", "test.pdf", "common_file.js");
 }
 
 IN_PROC_BROWSER_TEST_F(PDFExtensionTest, Bookmark) {
-  RunTestsInFile("bookmarks_test.js", "test-bookmarks.pdf");
+  RunTestsInFile("bookmarks_test.js", "test-bookmarks.pdf", "");
 }
+
+IN_PROC_BROWSER_TEST_F(PDFExtensionTest, NamedDestionations) {
+  RunTestsInFile("nameddestinations_test.js", "test.pdf", "common_file.js");
+}