Testcases for nameddests and navigate for PDF

chrome/browser/resources/pdf/pdf.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @return {number} Width of a scrollbar in pixels
  */
 function getScrollbarWidth() {
@@ skipping 138 matching lines @@
       // the zoom. onZoomChange() is called before setZoomComplete() callback
       // when we initiate the zoom.
       if ((zoomDelta > MIN_ZOOM_DELTA) && !this.setZoomInProgress_)
         this.viewport_.setZoom(zoomChangeInfo.newZoomFactor);
     }.bind(this));
   }
 
   // Parse open pdf parameters.
   this.paramsParser_ = new OpenPDFParamsParser();
   this.navigator_ = new Navigator(this.streamDetails_.originalUrl,
-      this.viewport_, this.paramsParser_);
+      this.viewport_, this.paramsParser_, this.onNavigateInCurrentTab_,
+      this.onNavigateInNewTab_);
 }
 
 PDFViewer.prototype = {
   /**
    * @private
    * Handle key events. These may come from the user directly or via the
    * scripting API.
    * @param {KeyboardEvent} e the event to handle.
    */
   handleKeyEvent_: function(e) {
@@ skipping 194 matching lines @@
    */
   onPasswordSubmitted_: function(event) {
     this.plugin_.postMessage({
       type: 'getPasswordComplete',
       password: event.detail.password
     });
   },
 
   /**
    * @private
+   * Called when navigation happens in the current tab.
+   * @param {string} url The url to be opened in the current tab.
+   */
+  onNavigateInCurrentTab_: function(url) {
+    window.location.href = url;
+  },

[raymes, 2015/02/01 23:50:38]

These don't need to be functions hanging off of PDFViewer. You can define them
outside of the class.

[Deepak, 2015/02/02 04:00:12]

Done.

+
+  /**
+   * @private
+   * Called when navigation happens in the new tab.
+   * @param {string} url The url to be opened in the new tab.
+   */
+  onNavigateInNewTab_: function(url) {
+    if (chrome.tabs)

[raymes, 2015/02/01 23:50:38]

We used to have a comment here, it disapeared!

[Deepak, 2015/02/02 04:00:12]

Done.

+      chrome.tabs.create({ url: url});
+    else
+      window.open(url);
+  },
+
+  /**
+   * @private
    * An event handler for handling message events received from the plugin.
    * @param {MessageObject} message a message event.
    */
   handlePluginMessage_: function(message) {
     switch (message.data.type.toString()) {
       case 'documentDimensions':
         this.documentDimensions_ = message.data;
         this.viewport_.setDocumentDimensions(this.documentDimensions_);
         // If we received the document dimensions, the password was good so we
         // can dismiss the password screen.
@@ skipping 310 matching lines @@
    * Each bookmark is an Object containing a:
    * - title
    * - page (optional)
    * - array of children (themselves bookmarks)
    * @type {Array} the top-level bookmarks of the PDF.
    */
   get bookmarks() {
     return this.bookmarks_;
   }
 };