Testcases for nameddests and navigate for PDF

chrome/browser/resources/pdf/navigator.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * Creates a new Navigator for navigating to links inside or outside the PDF.
  * @param {string} originalUrl The original page URL.
  * @param {Object} viewport The viewport info of the page.
  * @param {Object} paramsParser The object for URL parsing.
+ * @param {Function} navigateInCurrentTabCallback The Callback function that
+ *    gets called when navigation happens in the current tab.
+ * @param {Function} navigateInNewTabCallback The Callback function that gets
+ *    called when navigation happens in the new tab.
  */
-function Navigator(originalUrl, viewport, paramsParser) {
+function Navigator(originalUrl,
+                   viewport,
+                   paramsParser,
+                   navigateInCurrentTabCallback,
+                   navigateInNewTabCallback) {
   this.originalUrl_ = originalUrl;
   this.viewport_ = viewport;
   this.paramsParser_ = paramsParser;
+  this.navigateInCurrentTabCallback_ = navigateInCurrentTabCallback;
+  this.navigateInNewTabCallback_ = navigateInNewTabCallback;
 }
 
 Navigator.prototype = {
+
+  /**
+   * @private
+   * Called when navigation happens in the current tab.
+   * @param {string} url The url to be opened in the current tab.
+   */
+  navigateInCurrentTab_: function(url) {
+    window.location.href = url;
+    this.navigateInCurrentTabCallback_();
+  },
+
+  /**
+   * @private
+   * Called when navigation happens in the new tab.
+   * @param {string} url The url to be opened in the new tab.
+   */
+  navigateInNewTab_: function(url) {

[raymes, 2015/01/30 03:45:03]

These functions should be defined inside pdf.js and they should be passed into
navigator.

[Deepak, 2015/01/30 04:39:21]

Done.

+    if (chrome.tabs)
+      chrome.tabs.create({ url: url});
+    else
+      window.open(url);
+    this.navigateInNewTabCallback_();
+  },
+
    /**
    * @private
    * Function to navigate to the given URL. This might involve navigating
    * within the PDF page or opening a new url (in the same tab or a new tab).
    * @param {string} url The URL to navigate to.
    * @param {boolean} newTab Whether to perform the navigation in a new tab or
    *    in the current tab.
    */
   navigate: function(url, newTab) {
     if (url.length == 0)
@@ skipping 25 matching lines @@
     // Make sure inputURL is not only a scheme.
     if (url == 'http://' ||
         url == 'https://' ||
         url == 'ftp://' ||
         url == 'file://' ||
         url == 'mailto:') {
       return;
     }
 
     if (newTab) {
-      // Prefer the tabs API because it guarantees we can just open a new tab.
-      // window.open doesn't have this guarantee.
-      if (chrome.tabs)
-        chrome.tabs.create({ url: url });
-      else
-        window.open(url);
+      this.navigateInNewTab_(url);

[raymes, 2015/01/30 03:45:03]

this should just call this.navigateInNewTabCallback_();

[Deepak, 2015/01/30 04:39:21]

Done.

     } else {
       var pageNumber =
           this.paramsParser_.getViewportFromUrlParams(url).page;
       if (pageNumber != undefined)
         this.viewport_.goToPage(pageNumber);
       else
-        window.location.href = url;
+        this.navigateInCurrentTab_(url);

[raymes, 2015/01/30 03:45:03]

this should just call this.navigateInCurrentTabCallback_();

[Deepak, 2015/01/30 04:39:21]

Done.

     }
   }
 };