Testcases for nameddests and navigate for PDF

chrome/browser/resources/pdf/pdf_extension_test.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/base_paths.h"
 #include "base/files/file_util.h"
 #include "base/path_service.h"
 #include "chrome/browser/extensions/component_loader.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ skipping 55 matching lines @@
         url.spec());
     ui_test_utils::NavigateToURL(browser(), extension_url);
     content::WebContents* contents =
         browser()->tab_strip_model()->GetActiveWebContents();
     content::WaitForLoadStop(contents);
 
     base::FilePath test_data_dir;
     PathService::Get(base::DIR_SOURCE_ROOT, &test_data_dir);
     test_data_dir = test_data_dir.Append(
         FILE_PATH_LITERAL("chrome/test/data/pdf"));
-    test_data_dir = test_data_dir.AppendASCII(filename);
+

[raymes, 2015/01/29 04:27:13]

nit: no need to add a newline

[Deepak, 2015/01/29 06:05:41]

Done.

+    base::FilePath test_file_data_dir = test_data_dir.AppendASCII(filename);

[raymes, 2015/01/29 04:27:13]

this can be called "test_file_path"

[Deepak, 2015/01/29 06:05:41]

Done.

 
     std::string test_js;
-    ASSERT_TRUE(base::ReadFileToString(test_data_dir, &test_js));
+    ASSERT_TRUE(base::ReadFileToString(test_file_data_dir, &test_js));
+
+    std::string test_common_js;

[raymes, 2015/01/29 04:27:13]

test_util_js

[Deepak, 2015/01/29 06:05:41]

Done.

+    test_data_dir = test_data_dir.AppendASCII("test_util.js");

[raymes, 2015/01/29 04:27:13]

Create a separate base::FilePath here called "test_util_path

[Deepak, 2015/01/29 06:05:41]

Done.

+    ASSERT_TRUE(base::ReadFileToString(test_data_dir, &test_common_js));
+    test_js.append(test_common_js);

[raymes, 2015/01/29 04:27:13]

I would append the test_common_js before the test_js

[Deepak, 2015/01/29 06:05:41]

Done.

+
     ASSERT_TRUE(content::ExecuteScript(contents, test_js));
 
     if (!catcher.GetNextResult())
       FAIL() << catcher.message();
   }
 };
 
 IN_PROC_BROWSER_TEST_F(PDFExtensionTest, Basic) {
   RunTestsInFile("basic_test.js", "test.pdf");
 }
 
 IN_PROC_BROWSER_TEST_F(PDFExtensionTest, BasicPlugin) {
   RunTestsInFile("basic_plugin_test.js", "test.pdf");
 }
 
 IN_PROC_BROWSER_TEST_F(PDFExtensionTest, Viewport) {
   RunTestsInFile("viewport_test.js", "test.pdf");
 }
 
 IN_PROC_BROWSER_TEST_F(PDFExtensionTest, Bookmark) {
   RunTestsInFile("bookmarks_test.js", "test-bookmarks.pdf");
 }
+
+IN_PROC_BROWSER_TEST_F(PDFExtensionTest, Navigator) {
+  RunTestsInFile("navigator_test.js", "test.pdf");
+}
+
+IN_PROC_BROWSER_TEST_F(PDFExtensionTest, NamedDestionations) {
+  RunTestsInFile("params_parser_test.js", "test.pdf");
+}