Testcases for nameddests and navigate for PDF

chrome/browser/resources/pdf/navigator.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * Creates a new Navigator for navigating to links inside or outside the PDF.
  * @param {string} originalUrl The original page URL.
  * @param {Object} viewport The viewport info of the page.
  * @param {Object} paramsParser The object for URL parsing.
+ * @param {Object} navigateInCurrentTabCallback The Callback function that get

[raymes, 2015/01/29 04:27:13]

nit: get->gets
nit: {Object}->{Function}

[Deepak, 2015/01/29 06:05:41]

Done.

+ *    called when navigation happen in the current tab.

[raymes, 2015/01/29 04:27:13]

nit: happen->happens

[Deepak, 2015/01/29 06:05:41]

Done.

+ * @param {Object} navigateInNewTabCallback The Callback function that get

[raymes, 2015/01/29 04:27:13]

nit: get->gets
nit: {Object}->{Function}

[Deepak, 2015/01/29 06:05:41]

Done.

+ *    called when navigation happen in the new tab.

[raymes, 2015/01/29 04:27:13]

nit: happen->happens

[Deepak, 2015/01/29 06:05:41]

Done.

  */
-function Navigator(originalUrl, viewport, paramsParser) {
+function Navigator(originalUrl,
+                  viewport,

[raymes, 2015/01/29 04:27:13]

nit: indentation - please align with the (

[Deepak, 2015/01/29 06:05:41]

Done.

+                  paramsParser,
+                  navigateInCurrentTabCallback,
+                  navigateInNewTabCallback) {
   this.originalUrl_ = originalUrl;
   this.viewport_ = viewport;
   this.paramsParser_ = paramsParser;
+  this.navigateInCurrentTabCallback_ = navigateInCurrentTabCallback;
+  this.navigateInNewTabCallback_ = navigateInNewTabCallback;
 }
 
 Navigator.prototype = {
    /**
    * @private
    * Function to navigate to the given URL. This might involve navigating
    * within the PDF page or opening a new url (in the same tab or a new tab).
    * @param {string} url The URL to navigate to.
    * @param {boolean} newTab Whether to perform the navigation in a new tab or
    *    in the current tab.
@@ skipping 29 matching lines @@
     if (url == 'http://' ||
         url == 'https://' ||
         url == 'ftp://' ||
         url == 'file://' ||
         url == 'mailto:') {
       return;
     }
 
     if (newTab) {
       // Prefer the tabs API because it guarantees we can just open a new tab.
       // window.open doesn't have this guarantee.

[raymes, 2015/01/30 03:45:03]

Please keep this comment in the function that we pull out

+      this.navigateInNewTabCallback_();
       if (chrome.tabs)
         chrome.tabs.create({ url: url });
       else
         window.open(url);

[raymes, 2015/01/29 04:27:13]

We should remove the above 4 lines (and comment) now and pass them in as the
navigateInNewTabCallback function

[Deepak, 2015/01/29 06:05:41]

Done.

     } else {
       var pageNumber =
           this.paramsParser_.getViewportFromUrlParams(url).page;
-      if (pageNumber != undefined)
+      if (pageNumber != undefined) {
         this.viewport_.goToPage(pageNumber);
-      else
+      } else {
+        this.navigateInCurrentTabCallback_();
         window.location.href = url;

[raymes, 2015/01/29 04:27:13]

The same with this line - it should be passed in as the
navigateInCurrentTabCallback

[Deepak, 2015/01/29 06:05:41]

Done.

+      }
     }
   }
 };