Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: chrome/browser/download/download_browsertest.cc

Issue 838703002: Disable DownloadTest.DownloadTest_CrazyFilenames on Windows for flaky timeouts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <sstream> 5 #include <sstream>
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/files/file.h" 10 #include "base/files/file.h"
(...skipping 2939 matching lines...) Expand 10 before | Expand all | Expand 10 after
2950 (index == 0 ? std::string(".zip") : 2950 (index == 0 ? std::string(".zip") :
2951 base::StringPrintf(" (%d).zip", index)), 2951 base::StringPrintf(" (%d).zip", index)),
2952 target_path.BaseName().AsUTF8Unsafe()); 2952 target_path.BaseName().AsUTF8Unsafe());
2953 ASSERT_TRUE(base::PathExists(target_path)); 2953 ASSERT_TRUE(base::PathExists(target_path));
2954 ASSERT_TRUE(VerifyFile(target_path, origin_contents, 2954 ASSERT_TRUE(VerifyFile(target_path, origin_contents,
2955 origin_contents.size())); 2955 origin_contents.size()));
2956 } 2956 }
2957 } 2957 }
2958 2958
2959 // Test that the entire download pipeline handles unicode correctly. 2959 // Test that the entire download pipeline handles unicode correctly.
2960 IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadTest_CrazyFilenames) { 2960 // Disabled on Windows due to flaky timeouts: crbug.com/446695
2961 #if defined(OS_WIN)
2962 #define MAYBE_DownloadTest_CrazyFilenames DISABLED_DownloadTest_CrazyFilenames
2963 #else
2964 #define MAYBE_DownloadTest_CrazyFilenames DownloadTest_CrazyFilenames
2965 #endif
2966 IN_PROC_BROWSER_TEST_F(DownloadTest, MAYBE_DownloadTest_CrazyFilenames) {
2961 const wchar_t* kCrazyFilenames[] = { 2967 const wchar_t* kCrazyFilenames[] = {
2962 L"a_file_name.zip", 2968 L"a_file_name.zip",
2963 L"\u89c6\u9891\u76f4\u64ad\u56fe\u7247.zip", // chinese chars 2969 L"\u89c6\u9891\u76f4\u64ad\u56fe\u7247.zip", // chinese chars
2964 L"\u0412\u043e \u0424\u043b\u043e\u0440\u0438\u0434\u0435\u043e\u0431\u044a" 2970 L"\u0412\u043e \u0424\u043b\u043e\u0440\u0438\u0434\u0435\u043e\u0431\u044a"
2965 L"\u044f\u0432\u043b\u0435\u043d\u0440\u0435\u0436\u0438\u043c \u0427" 2971 L"\u044f\u0432\u043b\u0435\u043d\u0440\u0435\u0436\u0438\u043c \u0427"
2966 L"\u041f \u0438\u0437-\u0437\u0430 \u0443\u0442\u0435\u0447\u043a\u0438 " 2972 L"\u041f \u0438\u0437-\u0437\u0430 \u0443\u0442\u0435\u0447\u043a\u0438 "
2967 L"\u043d\u0435\u0444\u0442\u0438.zip", // russian 2973 L"\u043d\u0435\u0444\u0442\u0438.zip", // russian
2968 L"Desocupa\xe7\xe3o est\xe1vel.zip", 2974 L"Desocupa\xe7\xe3o est\xe1vel.zip",
2969 // arabic: 2975 // arabic:
2970 L"\u0638\u2026\u0638\u02c6\u0637\xa7\u0638\u201a\u0637\xb9 \u0638\u201e" 2976 L"\u0638\u2026\u0638\u02c6\u0637\xa7\u0638\u201a\u0637\xb9 \u0638\u201e"
(...skipping 542 matching lines...) Expand 10 before | Expand all | Expand 10 after
3513 *(downloads[0]))); 3519 *(downloads[0])));
3514 3520
3515 // Begin feedback and check that the file is "stolen". 3521 // Begin feedback and check that the file is "stolen".
3516 download_protection_service->feedback_service()->BeginFeedbackForDownload( 3522 download_protection_service->feedback_service()->BeginFeedbackForDownload(
3517 downloads[0]); 3523 downloads[0]);
3518 std::vector<DownloadItem*> updated_downloads; 3524 std::vector<DownloadItem*> updated_downloads;
3519 GetDownloads(browser(), &updated_downloads); 3525 GetDownloads(browser(), &updated_downloads);
3520 ASSERT_TRUE(updated_downloads.empty()); 3526 ASSERT_TRUE(updated_downloads.empty());
3521 } 3527 }
3522 #endif 3528 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698