Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 838683002: Reblacklist virtualCamera.ax, it's causing renderer hangs. (Closed)

Created:
5 years, 11 months ago by DaleCurtis
Modified:
5 years, 11 months ago
Reviewers:
Dale Curtis, csharp
CC:
chromium-reviews, caitkp+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reblacklist virtualCamera.ax, it's causing renderer hangs. This driver has persistent issues, we previously blacklisted it for http://crbug.com/378465 but came up with a workaround and thus it was allowed again. Now we're getting renderer hangs because it blocks a sync ipc from completing on the audio thread. Given the multiple issues and high install base, I think we should permanently blacklist this dll from loading. BUG=422522 TEST=none Committed: https://crrev.com/2354603b228bfe41c4490aff779084600576d627 Cr-Commit-Position: refs/heads/master@{#310556}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome_elf/blacklist/blacklist.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
DaleCurtis
Back on the blacklist.
5 years, 11 months ago (2015-01-06 22:45:32 UTC) #2
csharp
On 2015/01/06 22:45:32, DaleCurtis wrote: > Back on the blacklist. This will only prevent virtualCamera.ax ...
5 years, 11 months ago (2015-01-07 15:21:34 UTC) #3
Dale Curtis
Device enumeration is done in the browser process, so this should be sufficient?
5 years, 11 months ago (2015-01-07 19:04:08 UTC) #6
Dale Curtis
Device enumeration is done in the browser process, so this should be sufficient?
5 years, 11 months ago (2015-01-07 19:04:08 UTC) #7
csharp
lgtm
5 years, 11 months ago (2015-01-07 21:29:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838683002/1
5 years, 11 months ago (2015-01-08 02:05:06 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/110852) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/46652) android_arm64_dbg_recipe ...
5 years, 11 months ago (2015-01-08 02:08:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838683002/20001
5 years, 11 months ago (2015-01-08 02:17:30 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/92121)
5 years, 11 months ago (2015-01-08 10:57:43 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838683002/20001
5 years, 11 months ago (2015-01-08 18:13:30 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-08 19:14:31 UTC) #19
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 19:16:33 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2354603b228bfe41c4490aff779084600576d627
Cr-Commit-Position: refs/heads/master@{#310556}

Powered by Google App Engine
This is Rietveld 408576698