|
|
Chromium Code Reviews|
Created:
5 years, 11 months ago by DaleCurtis Modified:
5 years, 11 months ago CC:
chromium-reviews, caitkp+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReblacklist virtualCamera.ax, it's causing renderer hangs.
This driver has persistent issues, we previously blacklisted it for
http://crbug.com/378465 but came up with a workaround and thus it
was allowed again. Now we're getting renderer hangs because it
blocks a sync ipc from completing on the audio thread.
Given the multiple issues and high install base, I think we should
permanently blacklist this dll from loading.
BUG=422522
TEST=none
Committed: https://crrev.com/2354603b228bfe41c4490aff779084600576d627
Cr-Commit-Position: refs/heads/master@{#310556}
Patch Set 1 #Patch Set 2 : Rebase. #Messages
Total messages: 20 (8 generated)
dalecurtis@chromium.org changed reviewers: + csharp@chromium.org
Back on the blacklist.
On 2015/01/06 22:45:32, DaleCurtis wrote: > Back on the blacklist. This will only prevent virtualCamera.ax from loading into the browser process, it'll still be able to load into renderer processes. If you need to prevent it from loading into the renderer process, you'll need to add it here: https://code.google.com/p/chromium/codesearch#chromium/src/chrome_elf/blackli...
dalecurtis@google.com changed reviewers: + dalecurtis@google.com
dalecurtis@google.com changed reviewers: + dalecurtis@google.com
Device enumeration is done in the browser process, so this should be sufficient?
Device enumeration is done in the browser process, so this should be sufficient?
lgtm
The CQ bit was checked by dalecurtis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838683002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...) android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...) android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) android_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
The CQ bit was checked by dalecurtis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838683002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
The CQ bit was checked by dalecurtis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838683002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/2354603b228bfe41c4490aff779084600576d627 Cr-Commit-Position: refs/heads/master@{#310556} |
