Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: chrome/browser/download/download_danger_prompt_browsertest.cc

Issue 838673003: Disable DownloadDangerPromptTest.TestAll on Windows for flaky timeouts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_danger_prompt_browsertest.cc
diff --git a/chrome/browser/download/download_danger_prompt_browsertest.cc b/chrome/browser/download/download_danger_prompt_browsertest.cc
index d0ba0fa3fdfff542536dd54c8d277242274c9be5..2b33e0e7e29eed67d4d2c660cc8ffa0e157ee051 100644
--- a/chrome/browser/download/download_danger_prompt_browsertest.cc
+++ b/chrome/browser/download/download_danger_prompt_browsertest.cc
@@ -101,7 +101,13 @@ class DownloadDangerPromptTest : public InProcessBrowserTest {
DISALLOW_COPY_AND_ASSIGN(DownloadDangerPromptTest);
};
-IN_PROC_BROWSER_TEST_F(DownloadDangerPromptTest, TestAll) {
+// Disabled for flaky timeouts on Windows. crbug.com/446696
+#if defined(OS_WIN)
+#define MAYBE_TestAll DISABLED_TestAll
+#else
+#define MAYBE_TestAll TestAll
+#endif
+IN_PROC_BROWSER_TEST_F(DownloadDangerPromptTest, MAYBE_TestAll) {
// ExperienceSampling: Set default actions for DownloadItem methods we need.
ON_CALL(download(), GetURL()).WillByDefault(ReturnRef(GURL::EmptyGURL()));
ON_CALL(download(), GetReferrerUrl())
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698