runtime/vm/object_graph.cc - Issue 838663003: Make helper functions static to avoid accidental collision and potentially aid optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object_graph.cc

Issue 838663003: Make helper functions static to avoid accidental collision and potentially aid optimization. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object_graph.cc

===================================================================

--- runtime/vm/object_graph.cc (revision 42643)

+++ runtime/vm/object_graph.cc (working copy)

@@ -372,7 +372,7 @@

}

-void WritePtr(RawObject* raw, WriteStream* stream) {

+static void WritePtr(RawObject* raw, WriteStream* stream) {

ASSERT(raw->IsHeapObject());

ASSERT(raw->IsOldObject());

uword addr = RawObject::ToAddr(raw);

@@ -409,7 +409,7 @@

};

-void WriteHeader(RawObject* raw, intptr_t size, intptr_t cid,

+static void WriteHeader(RawObject* raw, intptr_t size, intptr_t cid,

WriteStream* stream) {

WritePtr(raw, stream);

ASSERT(Utils::IsAligned(size, kObjectAlignment));

« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/service.cc » ('j') | no next file with comments »