Make helper functions static to avoid accidental collision and potentially aid optimization.

runtime/vm/service.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/service.h"
 
 #include "include/dart_api.h"
 #include "platform/globals.h"
 
 #include "vm/compiler.h"
@@ skipping 234 matching lines @@
   GET_NON_NULL_NATIVE_ARGUMENT(Instance, message, arguments->NativeArgAt(0));
   Service::HandleRootMessage(message);
 }
 
 
 void Service::SetEventMask(uint32_t mask) {
   event_mask_ = mask;
 }
 
 
-void SetEventMask(Dart_NativeArguments args) {
+static void SetEventMask(Dart_NativeArguments args) {
   NativeArguments* arguments = reinterpret_cast<NativeArguments*>(args);
   Isolate* isolate = arguments->isolate();
   StackZone zone(isolate);
   HANDLESCOPE(isolate);
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, mask, arguments->NativeArgAt(0));
   Service::SetEventMask(mask.AsTruncatedUint32Value());
 }
 
 
 // These must be kept in sync with service/constants.dart
@@ skipping 543 matching lines @@
     jsobj.AddProperty("eventType", "_Echo");
     jsobj.AddProperty("isolate", isolate);
   }
   const String& message = String::Handle(String::New(js.ToCString()));
   uint8_t data[] = {0, 128, 255};
   // TODO(koda): Add 'testing' event family.
   SendEvent(kEventFamilyDebug, message, data, sizeof(data));
 }
 
 
-bool HandleIsolateEcho(Isolate* isolate, JSONStream* js) {
+static bool HandleIsolateEcho(Isolate* isolate, JSONStream* js) {
   JSONObject jsobj(js);
   jsobj.AddProperty("id", "_echo");
   if (js->num_arguments() == 2 && strcmp(js->GetArgument(1), "event") == 0) {
     Service::SendEchoEvent(isolate);
   }
   return HandleCommonEcho(&jsobj, js);
 }
 
 
 // Print an error message if there is no ID argument.
@@ skipping 73 matching lines @@
   if (end_ptr == s) {
     // String was not advanced at all, cannot be valid.
     return false;
   }
   *id = r;
   return true;
 }
 
 // Scans the string until the '-' character. Returns pointer to string
 // at '-' character. Returns NULL if not found.
-const char* ScanUntilDash(const char* s) {
+static const char* ScanUntilDash(const char* s) {
   if ((s == NULL) || (*s == '\0')) {
     // Empty string.
     return NULL;
   }
   while (*s != '\0') {
     if (*s == '-') {
       return s;
     }
     s++;
   }
@@ skipping 1856 matching lines @@
   while (current != NULL) {
     if (strcmp(name, current->name()) == 0) {
       return current;
     }
     current = current->next();
   }
   return NULL;
 }
 
 }  // namespace dart