Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Side by Side Diff: runtime/vm/intrinsifier_arm64.cc

Issue 838663003: Make helper functions static to avoid accidental collision and potentially aid optimization. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intrinsifier_arm.cc ('k') | runtime/vm/intrinsifier_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64.
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/intrinsifier.h" 8 #include "vm/intrinsifier.h"
9 9
10 #include "vm/assembler.h" 10 #include "vm/assembler.h"
(...skipping 1956 matching lines...) Expand 10 before | Expand all | Expand 10 after
1967 TryAllocateOnebyteString(assembler, &ok, &fall_through); 1967 TryAllocateOnebyteString(assembler, &ok, &fall_through);
1968 1968
1969 __ Bind(&ok); 1969 __ Bind(&ok);
1970 __ ret(); 1970 __ ret();
1971 1971
1972 __ Bind(&fall_through); 1972 __ Bind(&fall_through);
1973 } 1973 }
1974 1974
1975 1975
1976 // TODO(srdjan): Add combinations (one-byte/two-byte/external strings). 1976 // TODO(srdjan): Add combinations (one-byte/two-byte/external strings).
1977 void StringEquality(Assembler* assembler, intptr_t string_cid) { 1977 static void StringEquality(Assembler* assembler, intptr_t string_cid) {
1978 Label fall_through, is_true, is_false, loop; 1978 Label fall_through, is_true, is_false, loop;
1979 __ ldr(R0, Address(SP, 1 * kWordSize)); // This. 1979 __ ldr(R0, Address(SP, 1 * kWordSize)); // This.
1980 __ ldr(R1, Address(SP, 0 * kWordSize)); // Other. 1980 __ ldr(R1, Address(SP, 0 * kWordSize)); // Other.
1981 1981
1982 // Are identical? 1982 // Are identical?
1983 __ cmp(R0, Operand(R1)); 1983 __ cmp(R0, Operand(R1));
1984 __ b(&is_true, EQ); 1984 __ b(&is_true, EQ);
1985 1985
1986 // Is other OneByteString? 1986 // Is other OneByteString?
1987 __ tsti(R1, Immediate(kSmiTagMask)); 1987 __ tsti(R1, Immediate(kSmiTagMask));
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
2117 Isolate* isolate = Isolate::Current(); 2117 Isolate* isolate = Isolate::Current();
2118 __ LoadImmediate(R1, reinterpret_cast<uword>(isolate), kNoPP); 2118 __ LoadImmediate(R1, reinterpret_cast<uword>(isolate), kNoPP);
2119 // Set return value to Isolate::current_tag_. 2119 // Set return value to Isolate::current_tag_.
2120 __ ldr(R0, Address(R1, Isolate::current_tag_offset())); 2120 __ ldr(R0, Address(R1, Isolate::current_tag_offset()));
2121 __ ret(); 2121 __ ret();
2122 } 2122 }
2123 2123
2124 } // namespace dart 2124 } // namespace dart
2125 2125
2126 #endif // defined TARGET_ARCH_ARM64 2126 #endif // defined TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « runtime/vm/intrinsifier_arm.cc ('k') | runtime/vm/intrinsifier_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698